Bug#886938: [PATCH/GIT PULL] multipath-tools: Fix the dm-related udev rules

[Julian Andres Klode]

Package: multipath-tools
Version: 0.7.4-2
Severity: important
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch
Control: tag -1 patch

Hi, debian/rules does not install various udev rules, and some of the
udev rules are broken. Also debian/rules does not properly run dh_clean
at the end of the clean target.

I prepared a branch for you:

  pull https://git.launchpad.net/~juliank/+git/multipath-tools-debian rules-fixes

with the following changes:

Julian Andres Klode (6):
      Install dm-parts.rule
      Fix /usr/lib/udev to be /lib/udev
      Move udev rules at position 11 to position 56
      Fix 11-dm-mpath.rules to check for DM_UDEV_RULES, not DM_UDEV_RULES_VSN
      d/rules: Run dh_clean from clean target
      Install 68-del-part-nodes.rules

With this branch applied, the autopkgtests work better. We still have not
reached 0.6* levels yet, though. The loop tests fail (we have a patch in
Ubuntu, not sure if you want that or not), and multipathd eventually fails
when removing active devices in the second test case with multipathd becoming
confused and having non-existing devices. But at least the symlinks
and stuff are correctly generated now.

BTW: Instead of using dh_installudev like that, it might be better to just
patch the positions in the upstream makefiles and use dh_install to then
install the rules using dh_install. Then you can use dh_missing eventually
and don't accidentally not package new rules files.

Thanks,
Julian

-- System Information:
Debian Release: buster/sid
  APT prefers bionic
  APT policy: (500, 'bionic'), (100, 'bionic-proposed')
Architecture: amd64 (x86_64)

Kernel: Linux 4.14.0-16-generic (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages multipath-tools depends on:
ii  init-system-helpers  1.51
pn  kpartx               <none>
ii  libaio1              0.3.110-5
ii  libc6                2.26-0ubuntu2
ii  libdevmapper1.02.1   2:1.02.137-2ubuntu3
ii  librados2            12.2.2-0ubuntu1
ii  libreadline7         7.0-0ubuntu2
ii  libsystemd0          235-3ubuntu3
ii  libudev1             235-3ubuntu3
ii  liburcu6             0.10.0-2
ii  lsb-base             9.20170808ubuntu1
pn  sg3-utils-udev       <none>
ii  udev                 235-3ubuntu3

multipath-tools recommends no packages.

Versions of packages multipath-tools suggests:
pn  multipath-tools-boot  <none>

-- 
debian developer - deb.li/jak | jak-linux.org - free software dev
ubuntu core developer                              i speak de, en