[Pkg-lyx-devel] Re: dvipost (hopefully) ready for Debian

[Per Olofsson]

Hi,

Sven Hoexter:
> Hi all,
> yesterday I've been working on Matej Cepl's dvipost package
> so that it can stand the Debian QA and move into the main
> archive.
> 
> So if you've some spare time please give it a try and if you're
> familiar with Debian packages please look over the source package
> aswell.

Good work!

Some suggestions:

* It should be possible to have TeXlive installed instead of teTex. It
  should probably depend on tetex-bin | texlive-base-bin or something.
  
  BTW, is it really necessary to depend on TeX at all? Can't this
  package be used without TeX, if you have a DVI file? Maybe you
  should just recommend TeX instead?

* There are missing ending newlines in postinst and postrm.

* You should use dh_installtex instead of running texhash manually (I
  think). Have you read the TeX policy in the tex-common package? Also
  see the dh_installtex(1) manpage.

* Do you really need to create those directories listed in
  debian/dirs?

* The configure script checks things by running kpsewhich and
  tex. These are not listed in the Build-Depends. You should probably
  try to hardwire these values, or, if you must, build-depend on TeX.

* There are lintian errors. Please fix them.

* The package is configured two times when using debuild (which uses
  dpkg-buildpackage). The problem seems to be the patch target
  dependency. You should probably move the dependency from the
  config.status target to the build target (before build-stamp).

-- 
Pelle