[pkg-mad-maintainers] Bug#405801: [Fwd: Re: Regarding debian bug #405801.]

[Andreas Henriksson]

On lör, 2007-01-13 at 20:37 +0100, Kurt Roeckx wrote:

> > diff -urip libid3tag-0.15.1b/parse.c libid3tag-0.15.1b.fixed/parse.c
> > --- libid3tag-0.15.1b/parse.c	2004-01-23 10:41:32.000000000 +0100
> > +++ libid3tag-0.15.1b.fixed/parse.c	2007-01-13 18:35:42.000000000 +0100
> > @@ -165,6 +165,9 @@ id3_ucs4_t *id3_parse_string(id3_byte_t 
> >    case ID3_FIELD_TEXTENCODING_UTF_8:
> >      ucs4 = id3_utf8_deserialize(ptr, length);
> >      break;
> > +  default:
> > +    /* FIXME: Unknown encoding! Print warning? */
> > +    return NULL;
> >    }
> >  
> >    if (ucs4 && !full) {
> 
> This return NULL is useless, since it will already do that.

Yes, this part is not needed and isn't supposed to change anything. It
only seemed more obvious to me what was going on... Maybe not very
useful.

> 
> 
> Kurt
> 
-- 
Regards,
Andreas Henriksson