Bug#354000: madwifi-source: Should only recommend module-assistant

[Kel Modderman]

Julien Valroff wrote:

>Le jeudi 23 février 2006 à 07:04 +1000, Kel Modderman a écrit :
>  
>
>>Kel Modderman wrote:
>>
>>    
>>
>>>Julien Valroff wrote:
>>>
>>>      
>>>
>>>>Package: madwifi-source
>>>>Version: 0.svn20060207
>>>>Severity: wishlist
>>>>
>>>>As 2 build methods are clearly supported and explained in 
>>>>README.Debian, I think madwifi-source
>>>>should only recommend module-assistant (and not depend).
>>>>
>>>>As an alternative, the package could depend on m-a OR kernel-package.
>>>>
>>>>        
>>>>
>>>debian/rules.modules:-
>>>
>>>#!/usr/bin/make -f
>>>
>>>PACKAGE := madwifi-modules
>>>MA_DIR ?= /usr/share/modass
>>>-include $(MA_DIR)/include/generic.make
>>>-include $(MA_DIR)/include/common-rules.make
>>>. . .
>>>
>>>The package clearly depends on module-assistant.
>>>
>>>Thanks, Kel.
>>>
>>>      
>>>
>>That is not a strict dependency, however, I personally do not really 
>>want to demote module-assistant to Recommends, as most of the 
>>documentation I have written externally 
>>(http://madwifi.org/wiki/UserDocs/Distro/Debian) primarily describes 
>>module-assistant.
>>    
>>
>
>Thanks for answering quickly.
>
>I understand your point of view, but as aptitude pulls up recommended
>packages, and I think Synaptics does the same, m-a would be installed
>anyway in most cases, and people (like me) who don't use m-a could
>simply uninstall it.
>  
>

90% of the time i also use kernel-package, not m-a, but that is not the 
point. I believe m-a lays the best framework for the average user to 
easily install a module.

>Regarding the documentation, maybe it would be good to insist on the
>kernel-package method too.
>  
>

I would certainly enjoy receiving contributed documentation :-)

>I think the best thing is then to put a conditional dependency (Depends:
>module-assistant|kernel-package <...>).
>In this case, if none of the packages is already on the system, the
>first listed will be installed by apt.
>
>What do you think?
>  
>

This is the best suggestion so far, and I will be using module-assistant 
as first preference though.

Ok, i see two alternatives:-

1)
Package: madwifi-source
Architecture: all
Depends: debhelper (>= 4.1.0), build-essential, module-assistant | 
kernel-package, sharutils, bzip2

or

2)
Package: madwifi-source
Architecture: all
Depends: debhelper (>= 4.1.0), build-essential, module-assistant, 
sharutils, bzip2
Recommends: kernel-package

Which would you prefer? Would that be enough to satisfy your wish?

>Cheers,
>Julien
>
>  
>

Thanks, Kel.