Bug#433158: madwifi-source: fails to build on MIPS32 CPU

[Kel Modderman]

Hi Aurelien,

On Sun, 15 Jul 2007 09:42:36 am Aurelien Jarno wrote:
> Package: madwifi-source
> Version: 0.9.3-3
> Severity: important
> Tags: patch
>
> Hi,
>
> madwifi fails to build on MIPS32 CPU due to a bug in the build system.
> On those systems, the -mips1 option is passed to GCC, which conflicts
> with the -mips32 option passed by the kernel build system.
>
> Also the -EL or -EB options are issuing warnings, as they are only
> available on the other endianess system (-EL is available on mips, -EB
> on mipsel). The default endianess is sane, there is no need to force it,
> and anyway the kernel build system already handle that.
>
> The patch below fixes the problems for both mips and mipsel.

Thanks, for the patch.

I wonder, if you would like to have that patch applied upstream too?
If so, please consider signing off on the contribution.

http://madwifi.org/wiki/DevDocs/SigningPatches

> --- madwifi-0.9.3.orig/hal/public/mips1-le-elf.inc
> +++ madwifi-0.9.3/hal/public/mips1-le-elf.inc
> @@ -68,5 +68,5 @@
>
>  LDOPTS=	-EL
>  COPTS+=	-DAH_BYTE_ORDER=AH_LITTLE_ENDIAN
> -COPTS+=	-G 0 -EL -mno-abicalls -fno-pic -mips1 -Wa,--trap \
> +COPTS+=	-G 0 -mno-abicalls -fno-pic -Wa,--trap \
>  	-fno-strict-aliasing -fno-common -fomit-frame-pointer -mlong-calls
> --- madwifi-0.9.3.orig/hal/public/mips1-be-elf.inc
> +++ madwifi-0.9.3/hal/public/mips1-be-elf.inc
> @@ -68,5 +68,5 @@
>
>  LDOPTS=	-EB
>  COPTS+=	-DAH_BYTE_ORDER=AH_BIG_ENDIAN
> -COPTS+=	-G 0 -EB -mno-abicalls -fno-pic -mips1 -Wa,--trap \
> +COPTS+=	-G 0 -mno-abicalls -fno-pic -Wa,--trap \
>  	-fno-strict-aliasing -fno-common -fomit-frame-pointer -mlong-calls
>