[Pkg-mc-devel] Bug#549658: mc: NUMJOBS should be set by user DEB_MAKE_BUILD_TARGET

[Mathieu Malaterre]

Package: mc
Version: 2:4.6.2~git20080311-4
Severity: minor


As per 4.9.1 debian/rules and DEB_BUILD_OPTIONS
http://www.debian.org/doc/debian-policy/ch-source.html

I believe the following is incorrect:

  ifneq (,$(filter $(DEB_BUILD_ARCH),i386 amd64))
  NUMJOBS := $(shell getconf _NPROCESSORS_ONLN 2>/dev/null || echo 1)
  MAKEFLAGS += -j$(NUMJOBS)
  endif

it should be someting like:

  ifneq (,$(filter parallel=%,$(DEB_BUILD_OPTIONS)))
          NUMJOBS = $(patsubst parallel=%,%,$(filter
  parallel=%,$(DEB_BUILD_OPTIONS)))
          DEB_MAKE_BUILD_TARGET = -j$(NUMJOBS) all
  endif

Thanks

-- System Information:
Debian Release: 5.0.2
  APT prefers stable
  APT policy: (500, 'stable'), (200, 'testing'), (100, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.30-bpo.1-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages mc depends on:
ii  libc6                         2.9-25     GNU C Library: Shared libraries
ii  libglib2.0-0                  2.20.1-2   The GLib library of C routines
ii  libgpm2                       1.20.4-3.1 General Purpose Mouse - shared lib
ii  libslang2                     2.1.3-3    The S-Lang programming library - r

mc recommends no packages.

Versions of packages mc suggests:
ii  arj                      3.10.22-6       archiver for .arj files
ii  bzip2                    1.0.5-1         high-quality block-sorting file co
pn  dbview                   <none>          (no description available)
ii  file                     5.03-1          Determines file type using "magic"
ii  links                    2.1pre37-1.1    Web browser running in text mode
ii  lynx                     2.8.7dev9-2.1   Text-mode WWW Browser (transitiona
ii  mime-support             3.44-1          MIME files 'mime.types' & 'mailcap
pn  odt2txt                  <none>          (no description available)
ii  perl                     5.10.0-19lenny2 Larry Wall's Practical Extraction 
ii  unzip                    5.52-12         De-archiver for .zip files
ii  w3m                      0.5.2-2+b1      WWW browsable pager with excellent
ii  xpdf                     3.02-1.4+lenny1 Portable Document Format (PDF) sui
ii  zip                      2.32-1          Archiver for .zip files

-- no debconf information