[Pkg-mc-devel] Midnight Comander 4.8.1 [RFS]

[Dmitry Smirnov]

Hi Andreas,

Thank you for quick response and for your attention to the package.

On Sunday 26 February 2012 02:33:49 Andreas Tille wrote:
> thanks for all your work on mc.  The changelog looks really impressive.

The pleasure is mine. :)

> > > And yeah, another idea: also maybe you can replace raster icons with
> > > the render from svg and change all names to midnight-commander for
> > > consistency (mc is too short to avoid conflicts, I'm afraid)...
> > 
> > I could, but is it really necessary to do everything in one go?
> 
> IMHO it is better to get that real lot of fixes out as fast as possible
> and do cosmetics later.

True, with new version uploaded it'll be easier to squash old bugs.


> > If I stay at least for some time I might have a chance to prepare another
> > upload. :)
> 
> Sounds promising.

:)  
I have some plans for next release.
On BTS I've seen some yummy patches to incorporate and to forward...

Forwarding patches appears to be a next priority because we already 
diverging from upstream...


> IMHO the bugs.txt file makes sense when working offline.  I think
> maintaining this file is not mandatory for an upload because while its
> helpful for other developers as well it is not visible to users who just
> want to recive the new package (urgently).

Personally I'd prefer BTS tags/usertags. 

bugs.txt was imported from SVN, so I'll keep it until I'll be sure there is 
nothing valuable left in it.


> The only thing which might be interesting to do before an upload whould
> IMHO be if Maarten would check the according Launchpad bugs and add
> these to the changelog.  However, this should also be no real reason for
> a delay because I guess these could also be closed manually.

Changelog is already big enough and we can always close bugs in BTS.
If we ready for upload let's upload and continue working. 
This upload is not the last chance... :)


> I have some remarks to your work.  When adding a remark about the
> changed VCS the SVN commit hook sended a mail to *this* list
> (pkg-mc-devel).  My recent change in the new repository where I bumped
> the Standards-Version to the recently released policy version went via
> Commit hook to the commit list (pkg-mc-commits).  I think the new
> behaviour is perfectly OK but want to mention here that the general
> behaviour has changed.  Please everybody who is involved notice this.

Thanks for bumping standards and for this information.

 
> Another think I noticed is that my long used alias
> 
>    alias mc='. /usr/share/mc/bin/mc-wrapper.sh'
> 
> is not working any more.  It either needs to be replaced by
> 
>    alias mc='. /usr/lib/mc/mc-wrapper.sh'
> 
> and this should be mentioned in a NEWS.debian entry or we need to find
> some in-package means to keep the old behaviour working (either via a
> symlink to the old location or using the alias system).  I have no
> opinion what might be the best option, but we should probably not leave
> this issue unhandled.

It's great you've noticed this. I just pushed an update introducing symlink 
for mc-wrapper.sh

I think generally users might expect such changes when upgrading to new major 
release but indeed symlink approach will be more comfortable for users than 
NEWS.debian warning.

Please excuse me for lack of experience but does this little thing really 
qualify for NEWS.debian? (I just never had a chance to use it before).
My doubts regarding this are because I'm not sure if NEWS.debian notice should 
be issued when only user's customisations are affected (which may not be 
considered under maintainer's responsibilities).


Regards,
Dmitry.