[Pkg-mc-devel] [Bug 1094324] Re: "Delete tagged files if a copy exists in the other directory" doesn't work if names of the files or folders contains space

[Mantas Kriaučiūnas]

Hi Yury,

Yury V. Zaytsev (zyv) wrote on 2013-03-05: 
> I pushed upstream a different patch from what you suggested, but I believe it should still work.

Your patch doesn't fix the problem - I'm attaching correct patch against mc.menu from mc 4.8.8 which fixes identical files deletion when folders and/or files names contains spaces.
Problem in your patch was quoted %D - see this line in your patch:
  if [ -f "%D/$i" ]; then
because of quoted %D deletion doesn't work: mc doesn't even find identical files - I get a message "FILENAME has no copy in /tmp/folder\ with\ space: NOT deleted." in terminal.
Deletion works correctly when %D isn't quoted, only $i is quoted:
  if [ -f %D/"$i" ]; then

I hope you understand why your patch doesn't work and you will forward
my patch to mc upstream ;)

** Patch added: "Correct patch against 4.8.8 mc.menu which fixes identical files deletion when folders/files names contains spaces"
   https://bugs.launchpad.net/baltix/+source/mc/+bug/1094324/+attachment/3623084/+files/mc.menu.folders-and-files-with-spaces-deletion-fix-4.8.8.patch

-- 
You received this bug notification because you are a member of Debian MC
Packaging Group, which is subscribed to Midnight Commander.
https://bugs.launchpad.net/bugs/1094324

Title:
  "Delete tagged files if a copy exists in the other directory" doesn't
  work if names of the files or folders contains space

Status in Midnight Commander - text-mode file manager:
  Fix Released
Status in “mc” package in Ubuntu:
  In Progress
Status in “mc” package in Baltix:
  New

Bug description:
  Midnight commander has nice feature - you can mark some file in one side and MC can compare these files with identically named files in other side and remove them if files are identical. This function can be started from the "User menu" (key F2) and is named"
  "D  Delete tagged files if a copy exists in the other directory"
  But "Delete tagged files if a copy exists in the other directory" doesn't work if names of the files or folders contains space :(
  Problem is in /etc/mc/mc.menu - I'm attaching a patch against mc.menu, which fixes this problem - I've tested with mc from Ubuntu 12.04 and newer :)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mc/+bug/1094324/+subscriptions