NeilBrown: Assemble: allow --force to work even when event counts are 0.

Martin F. Krafft madduck at alioth.debian.org
Mon Feb 16 10:52:40 UTC 2009


Module: mdadm
Branch: master
Commit: d555f101466ab9ad72399c8de92713230e2c9c77
URL:    http://git.debian.org/?p=pkg-mdadm/mdadm.git;a=commit;h=d555f101466ab9ad72399c8de92713230e2c9c77

Author: NeilBrown <neilb at suse.de>
Date:   Thu Nov 27 15:46:51 2008 +1100

Assemble: allow --force to work even when event counts are 0.

If any superblocks in a confused array had an event count of 0,
"mdadm -Af" would not update the event counts to assemble the array.
I don't remember why that text is there, and it has caused at least
one situation to be difficult to recover from.  So remove the
test.  --force means --force!

Signed-off-by: NeilBrown <neilb at suse.de>

---

 Assemble.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/Assemble.c b/Assemble.c
index 79f0912..1d37870 100644
--- a/Assemble.c
+++ b/Assemble.c
@@ -632,7 +632,6 @@ int Assemble(struct supertype *st, char *mddev, int mdfd,
 			int j = best[i];
 			if (j>=0 &&
 			    !devices[j].uptodate &&
-			    devices[j].i.events > 0 &&
 			    (chosen_drive < 0 ||
 			     devices[j].i.events
 			     > devices[chosen_drive].i.events))
@@ -690,7 +689,6 @@ int Assemble(struct supertype *st, char *mddev, int mdfd,
 			int j = best[i];
 			if (j >= 0 &&
 			    !devices[j].uptodate &&
-			    devices[j].i.events > 0 &&
 			    devices[j].i.events == current_events) {
 				chosen_drive = j;
 				goto add_another;




More information about the pkg-mdadm-commits mailing list