Dan Williams: imsm: turn off curr_migr_unit updates

Martin F. Krafft madduck at alioth.debian.org
Thu May 7 12:11:41 UTC 2009


Module: mdadm
Branch: debian/experimental
Commit: da1887895404506708387fa3781bf0df0a2664ff
URL:    http://git.debian.org/?p=pkg-mdadm/mdadm.git;a=commit;h=da1887895404506708387fa3781bf0df0a2664ff

Author: Dan Williams <dan.j.williams at intel.com>
Date:   Sun Apr 12 00:58:28 2009 -0700

imsm: turn off curr_migr_unit updates

New documentation shows that this field is not equivalent to
md/resync_start.  Disable updates until full support can be developed.

Writing '0' when a migration starts/re-starts remains correct.

Signed-off-by: Dan Williams <dan.j.williams at intel.com>



---

 super-intel.c |   11 +++--------
 1 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/super-intel.c b/super-intel.c
index 41e9168..3befc3d 100644
--- a/super-intel.c
+++ b/super-intel.c
@@ -1218,7 +1218,8 @@ static void getinfo_super_imsm_volume(struct supertype *st, struct mdinfo *info)
 	if (map->map_state == IMSM_T_STATE_UNINITIALIZED || dev->vol.dirty)
 		info->resync_start = 0;
 	else if (dev->vol.migr_state)
-		info->resync_start = __le32_to_cpu(dev->vol.curr_migr_unit);
+		/* FIXME add curr_migr_unit to resync_start conversion */
+		info->resync_start = 0;
 	else
 		info->resync_start = ~0ULL;
 
@@ -3684,13 +3685,7 @@ static int imsm_set_array_state(struct active_array *a, int consistent)
 		super->updates_pending++;
 	}
 
-	/* check if we can update the migration checkpoint */
-	if (dev->vol.migr_state &&
-	    __le32_to_cpu(dev->vol.curr_migr_unit) != a->resync_start) {
-		dprintf("imsm: checkpoint migration (%llu)\n", a->resync_start);
-		dev->vol.curr_migr_unit = __cpu_to_le32(a->resync_start);
-		super->updates_pending++;
-	}
+	 /* FIXME check if we can update curr_migr_unit from resync_start */
 
 	/* mark dirty / clean */
 	if (dev->vol.dirty != !consistent) {




More information about the pkg-mdadm-commits mailing list