Dan Williams: Remove 'checkpointing' side effect of --wait-clean

Martin F. Krafft madduck at alioth.debian.org
Sun Aug 29 11:54:53 UTC 2010


Module: mdadm
Branch: fixes/udev-blkid
Commit: 6a0ee6a0770e8b2ae2a2bbe79896d4ecb083e218
URL:    http://git.debian.org/?p=pkg-mdadm/mdadm.git;a=commit;h=6a0ee6a0770e8b2ae2a2bbe79896d4ecb083e218

Author: Dan Williams <dan.j.williams at intel.com>
Date:   Tue Jun 15 18:41:57 2010 -0700

Remove 'checkpointing' side effect of --wait-clean

Now that mdmon records periodic checkpoints, and checkpoints every
->set_array_state() event we no longer need to 'idle' sync_action from
--wait-clean.

Signed-off-by: Dan Williams <dan.j.williams at intel.com>

---

 mdadm.8 |    7 ++-----
 sysfs.c |    3 ---
 2 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/mdadm.8 b/mdadm.8
index 4edfc41..aa2b12f 100644
--- a/mdadm.8
+++ b/mdadm.8
@@ -1195,14 +1195,11 @@ listed, otherwise it will return failure.
 For each md device given, or each device in /proc/mdstat if
 .B \-\-scan
 is given, arrange for the array to be marked clean as soon as possible.
-Also, quiesce resync so that the monitor for external metadata arrays
-(mdmon) has an opportunity to checkpoint the resync position.
 .I mdadm
 will return with success if the array uses external metadata and we
 successfully waited.  For native arrays this returns immediately as the
-kernel handles both dirty-clean transitions and resync checkpointing in
-the kernel at shutdown.  No action is taken if safe-mode handling is
-disabled.
+kernel handles dirty-clean transitions at shutdown.  No action is taken
+if safe-mode handling is disabled.
 
 .SH For Incremental Assembly mode:
 .TP
diff --git a/sysfs.c b/sysfs.c
index ebf9d8a..72c7c5b 100644
--- a/sysfs.c
+++ b/sysfs.c
@@ -852,9 +852,6 @@ int WaitClean(char *dev, int sock, int verbose)
 		tm.tv_sec = 5;
 		tm.tv_usec = 0;
 
-		/* give mdmon a chance to checkpoint resync */
-		sysfs_set_str(mdi, NULL, "sync_action", "idle");
-
 		FD_ZERO(&fds);
 
 		/* wait for array_state to be clean */




More information about the pkg-mdadm-commits mailing list