Dan Williams: imsm: no need to report the component device name from container_content

Martin F. Krafft madduck at alioth.debian.org
Wed Jan 27 02:03:50 UTC 2010


Module: mdadm
Branch: upstream
Commit: c3ca5f60282b263808dff6b0b77538d2207c3568
URL:    http://git.debian.org/?p=pkg-mdadm/mdadm.git;a=commit;h=c3ca5f60282b263808dff6b0b77538d2207c3568

Author: Dan Williams <dan.j.williams at intel.com>
Date:   Thu Dec 10 12:03:39 2009 -0700

imsm: no need to report the component device name from container_content

sysfs_add_disk() regenerates the name from major:minor, so we can drop a
strcpy that the static analysis checker does not like.

Reported-by: Artur Wojcik <artur.wojcik at intel.com>
Signed-off-by: Dan Williams <dan.j.williams at intel.com>

---

 super-intel.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/super-intel.c b/super-intel.c
index 5cc78f5..cf6288f 100644
--- a/super-intel.c
+++ b/super-intel.c
@@ -3878,8 +3878,6 @@ static struct mdinfo *container_content_imsm(struct supertype *st)
 			info_d->events = __le32_to_cpu(mpb->generation_num);
 			info_d->data_offset = __le32_to_cpu(map->pba_of_lba0);
 			info_d->component_size = __le32_to_cpu(map->blocks_per_member);
-			if (d->devname)
-				strcpy(info_d->name, d->devname);
 		}
 		rest = this;
 	}




More information about the pkg-mdadm-commits mailing list