Doug Ledford: Fix segfault when the AUTO keyword is used in the config file

Martin F. Krafft madduck at alioth.debian.org
Wed Jan 27 02:04:19 UTC 2010


Module: mdadm
Branch: upstream
Commit: 4d0b563b5b5597cc1467e3560f87fc3a144223a2
URL:    http://git.debian.org/?p=pkg-mdadm/mdadm.git;a=commit;h=4d0b563b5b5597cc1467e3560f87fc3a144223a2

Author: Doug Ledford <dledford at redhat.com>
Date:   Mon Jan 11 15:38:14 2010 -0500

Fix segfault when the AUTO keyword is used in the config file

Signed-off-by: Doug Ledford <dledford at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>

---

 config.c |   11 ++++++++++-
 1 files changed, 10 insertions(+), 1 deletions(-)

diff --git a/config.c b/config.c
index c962afd..07a12dc 100644
--- a/config.c
+++ b/config.c
@@ -677,12 +677,21 @@ void homehostline(char *line)
 static char *auto_options = NULL;
 void autoline(char *line)
 {
+	char *w;
+
 	if (auto_options) {
 		fprintf(stderr, Name ": AUTO line may only be give once."
 			"  Subsequent lines ignored\n");
 		return;
 	}
-	auto_options = line;		
+
+	auto_options = dl_strdup(line);
+	dl_init(auto_options);
+
+	for (w=dl_next(line); w != line ; w=dl_next(w)) {
+		char *w2 = dl_strdup(w);
+		dl_add(auto_options, w2);
+	}
 }
 
 int loaded = 0;




More information about the pkg-mdadm-commits mailing list