Alexander Lyakas: Don' t consider disks with a valid recovery offset as candidates for bumping up event count

Michael Tokarev mjt at alioth.debian.org
Fri May 25 18:01:38 UTC 2012


Module: mdadm
Branch: master
Commit: 135a31f5ed39dfc5d0288fac7ae8af8f5b2ae233
URL:    http://git.debian.org/?p=pkg-mdadm/mdadm.git;a=commit;h=135a31f5ed39dfc5d0288fac7ae8af8f5b2ae233

Author: Alexander Lyakas <alex.bolshoy at gmail.com>
Date:   Sun May 13 10:10:43 2012 +0300

Don't consider disks with a valid recovery offset as candidates for bumping up event count

When we are looking for a candidate disk to bump up the event count,
we consider only disks that have recovery_start==MaxSector.
However, after we find one such disk, we agree to accept more disks
having same event count, regardless of their recovery_start.
Be consistent and don't accept disks with a valid recovery_start at all.

Signed-off-by: NeilBrown <neilb at suse.de>

---

 Assemble.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/Assemble.c b/Assemble.c
index 080993d..227d66f 100644
--- a/Assemble.c
+++ b/Assemble.c
@@ -1069,6 +1069,7 @@ int Assemble(struct supertype *st, char *mddev,
 			int j = best[i];
 			if (j >= 0 &&
 			    !devices[j].uptodate &&
+			    devices[j].i.recovery_start == MaxSector &&
 			    devices[j].i.events == current_events) {
 				chosen_drive = j;
 				goto add_another;




More information about the pkg-mdadm-commits mailing list