Bug#525655: /usr/share/initramfs-tools/hooks/mdadm: warnings

[martin f krafft]

also sprach Cristian Ionescu-Idbohrn <cristian.ionescu-idbohrn at axis.com> [2009.04.26.1920 +0200]:
> > Inside $(), I can use "" without quoting them again.
> 
> Still.  Outside quotes are useless.  $(...) protects the resulting string.

+1 for things learnt today! \o/

> > That's one of the great things about $() over ``.
> 
> Right.  Why not use it through the whole script then?  Here's another
> spot:
> 
> -	rubbish=`echo $rubbish | sed 's/metadata=[^ ]* //'`
> +	rubbish=$(echo $rubbish | sed 's/metadata=[^[:blank:]]*[[:blank:]]//')

That was contributed by someone else and I didn't catch it.

> > > -PREREQ=""
> > > +PREREQ=
> >
> > I don't see the real difference.
> 
> That's 2 bytes shorter.

I also find it a bit less expressive, and

> > > -  devs=''; levels=''
> > > +  devs=; levels=

that's even a bit confusing to me.

-- 
 .''`.   martin f. krafft <madduck at d.o>      Related projects:
: :'  :  proud Debian developer               http://debiansystem.info
`. `'`   http://people.debian.org/~madduck    http://vcs-pkg.org
  `-  Debian - when you have better things to do than fixing systems
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature (see http://martin-krafft.net/gpg/)
URL: <http://lists.alioth.debian.org/pipermail/pkg-mdadm-devel/attachments/20090426/49191b0d/attachment.pgp>