Bug#549083: Not working with 3.0.3-2
martin f krafft
madduck at debian.org
Mon Nov 9 07:44:49 UTC 2009
unmerge 549083
retitle 549083 initramfs hook introduces single quotes into homehost name
reopen 549083
notfixed 549083
tags 549083 patch
thanks
also sprach Neil Brown <neilb at suse.de> [2009.11.09.0534 +0100]:
> [ -n "${MD_HOMEHOST:-}" ] && extra_args="--homehost='$MD_HOMEHOST'"
> if $MDADM --assemble --scan --run --auto=yes $extra_args; then
>
> That is wrong.
> It will cause the --homehost string given to mdadm to have single
> quotes around it. It should be
>
> [ -n "${MD_HOMEHOST:-}" ] && extra_args="--homehost=$MD_HOMEHOST"
> if $MDADM --assemble --scan --run --auto=yes ${extra_args:+"$MD_HOMEHOST"}; then
Will be in next upload. Does this work for you?
diff --git a/debian/initramfs/script.local-top b/debian/initramfs/script.local-top
index 0148f24..0458e17 100644
--- a/debian/initramfs/script.local-top
+++ b/debian/initramfs/script.local-top
@@ -75,9 +75,8 @@ echo 1 > /sys/module/md_mod/parameters/start_ro
if [ "$MD_DEVS" = all ]; then
verbose && log_begin_msg "Assembling all MD arrays"
- extra_args=''
- [ -n "${MD_HOMEHOST:-}" ] && extra_args="--homehost='$MD_HOMEHOST'"
- if $MDADM --assemble --scan --run --auto=yes $extra_args; then
+ [ -n "${MD_HOMEHOST:-}" ] && extra_args="--homehost=$MD_HOMEHOST"
+ if $MDADM --assemble --scan --run --auto=yes${extra_args:+ $extra_args}; then
verbose && log_success_msg "assembled all arrays."
else
log_failure_msg "failed to assemble all arrays."
--
.''`. martin f. krafft <madduck at d.o> Related projects:
: :' : proud Debian developer http://debiansystem.info
`. `'` http://people.debian.org/~madduck http://vcs-pkg.org
`- Debian - when you have better things to do than fixing systems
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature (see http://martin-krafft.net/gpg/)
URL: <http://lists.alioth.debian.org/pipermail/pkg-mdadm-devel/attachments/20091109/8800b251/attachment.pgp>
More information about the pkg-mdadm-devel
mailing list