Bug#641155: pu: package mdadm/3.1.4-1+8efb9d1+squeeze1

Adam D. Barratt adam at adam-barratt.org.uk
Sat Jan 14 15:50:25 UTC 2012


On Tue, 2012-01-10 at 12:33 +0400, Michael Tokarev wrote:
> So, after quite some time, I'm attempting another upload of mdadm to
> stable-pu.  All the changes were sitting in testing for half a year,
> and were backported into stable/squeeze version.
> 
> As before, the proposed changes are only in debian-specific areas of
> the package, fixing several bugs in supporting/maintenance scripts.
> Complete debdiff is attached.

Thanks for this.  A few (hopefully) quick queries.

+  * Fix checkarray script so that it does not die after scheduling the first
+    device when there is no scheduling class specified; thanks to Mario
+    'BitKoenig' Holbe (closes: #611627).

The fix for this includes this change:

-          ionice -p "$resync_pid" $arg
+          ionice -p "$resync_pid" $arg || :

I assume this is because $arg is unset and the ionice invocation thus
fails?  Wouldn't it better to check that the arguments are sane before
attempting to run ionice instead?

+  * Schedule start/stop of mdadm-raid before/after filesystems are
+    checked&mounted/unmounted; thanks to Mario 'BitKoenig' Holbe
+    (closes: #611632).
[...]
+  * Make mdadm-raid init script depend on hostname; thanks to Mario
+   'BitKoenig' Holbe (closes: #610421).

Have these changes to the LSB headers been tested on squeeze systems?

+  * Schedule start/stop of mdadm-raid before/after filesystems are
+    checked&mounted/unmounted; thanks to Mario 'BitKoenig' Holbe
+    (closes: #611632).

This change appears twice in the changelog.  Is this purely an editorial
issue or is there another change which isn't mentioned in the changelog?

Regards,

Adam




More information about the pkg-mdadm-devel mailing list