[Pkg-mediawiki-commits] r170 - mediawiki-extensions/trunk

[Thorsten Glaser]

Author: tg
Date: 2010-06-28 13:08:28 +0000 (Mon, 28 Jun 2010)
New Revision: 170

Modified:
   mediawiki-extensions/trunk/check_versions.pl
Log:
some minor optimisations (my Perl is almost nonexistent)
and skip empty lines too, not just lines with a hash sign


Modified: mediawiki-extensions/trunk/check_versions.pl
===================================================================
--- mediawiki-extensions/trunk/check_versions.pl	2010-06-28 13:01:45 UTC (rev 169)
+++ mediawiki-extensions/trunk/check_versions.pl	2010-06-28 13:08:28 UTC (rev 170)
@@ -26,7 +26,7 @@
 
 sub latest_revision {
   my $url = shift ;
-  my $latest_revision = `LC_ALL=C svn info $url | grep "Last Changed Rev" | sed -e "s#Last Changed Rev: ##"`;
+  my $latest_revision = `LC_ALL=C svn info $url | LC_ALL=C sed -n '/^Last Changed Rev: /s///p'`;
   $latest_revision =~ s/[\r\n\/]+$//;
   return $latest_revision ;
 }
@@ -46,7 +46,7 @@
   for (@added) { $is_added{$_} = 1; }
   print "Checking other files in the same directory...\n" ;
   foreach $new_file (@lines) {
-    my $exists = `cat "$file" | grep "$new_file"` ;
+    my $exists = `grep "$new_file" <"$file"` ;
     my @filtered = grep(/$new_file/, at blacklist);
     print "Checking: $new_file\n";
     my $size = @filtered;
@@ -139,7 +139,7 @@
 
 while (<F>) {
   print "Processing line: $_" if defined $options{v};
-  next if (/^\s*#/);
+  next if (/^\s*(#.*)$/);
   /^(.+)\s-\s(.+)\s-\s(.+)\s-\s(.+)\s-\s(.+)\s-\s(\d+)/;
   my ($url,$extname,$package,$basedir,$link,$revision) = ($1,$2,$3,$4,$5,$6);
   $revision = 0 if defined $options{u};