[Pkg-mediawiki-devel] Bug#472283: mediawiki-extensions: LDAP authentication extension fails to identify unused names

[Jamie Thompson]

Package: mediawiki-extensions
Version: 1.3
Severity: normal


When LdapAuthenticationPlugin::getSearchString() returns an empty string and smartcard auth is not used, the search is performed, but returns a result on my setup:

$entry = Array
(
    [count] => 1
    [0] => Array
        (
            [objectclass] => Array
                (
                    [count] => 2
                    [0] => top
                    [1] => OpenLDAProotDSE
                )

            [0] => objectclass
            [count] => 1
            [dn] => 
        )

)

My quick and dirty solution is to change:
(LdapAuthenticationPlugin.php at 112)
//Search for the entry.
$entry = @ldap_read( $ldapconn, $searchstring, "objectclass=*" );

to:
//Search for the entry.
if ( $searchstring != '' )
	$entry = @ldap_read( $ldapconn, $searchstring, "objectclass=*" );

This gives me the correct behaviour.

...and just for completeness, I'm not using the smartcard stuff, if that helps.

-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (900, 'testing'), (600, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.22-3-686 (SMP w/1 CPU core)
Locale: LANG=en_GB, LC_CTYPE=en_GB (charmap=ISO-8859-1)
Shell: /bin/sh linked to /bin/bash

Versions of packages mediawiki-extensions depends on:
ii  mediawiki                     1:1.11.2-2 website engine for collaborative w

Versions of packages mediawiki-extensions recommends:
ii  php-geshi                     1.0.7.20-1 Generic Syntax Highlighter
ii  php5-ldap                     5.2.5-3    LDAP module for php5
ii  python                        2.4.4-6    An interactive high-level object-o
ii  python-imaging                1.1.6-1    Python Imaging Library

-- no debconf information