[Pkg-mediawiki-devel] Skins

Tue Jul 3 14:12:33 UTC 2012

On 12-07-03 12:32 AM, Thorsten Glaser wrote:
> On Mon, 2 Jul 2012, Daniel Friesen wrote:
>
>> Tell me what you're trying to add to the <head>. Inevitably anything
>> you're trying to do should be doable without dropping headelement.
> Right now, that’s a few things, some of them might be doable,
> for some I didn’t find a way. This is from reading the diff
> against the 1.15 MonoBook, so it may not be accurate (have
> been working on this again yesterday, but still not “deep in”).
>
> • put some stuff before </title> after what’s normally written there
Could you clarify what you want to add.
The title is controllable in OutputPage so if you want to add some text
to the title it should be possible.

> • call a FusionForge function that displays the needed CSS for that
>   (which in turn echo’s stuff that can be gotten by an API call, but
>   also calls a plugin hook; the FF plugin API is totally misdesigned
>   as the hooks are expected to echo stuff when written, instead of
>   adding content to some variable that can be echo’d when needed)
Without seeing what's outputted I'm not sure whether you should be using
output buffering and which of addInlineStyle or addHeadItem you should use.

> • then, there's a patch that prevents MW from echoing <ul></ul> as
>   that’s invalid XHTML, no idea if it’s still needed
You're not trying to make your own skin?

Do you have a good good reason for XHTML to be your target?
Because XHTML 1.x is dead. Validity using those old rules doesn't matter
anymore. If you really need XML's extensibility there's XHTML5.

> • change $footerlinks
Naturally, modify $this->data['footerlinks'] from the *Template class.
Though, the sane person would use SkinTemplateOutputPageBeforeExec and
$tpl so that the modifications show up in all skins.

> The rest, I’ve got already. Then, there are several occurrences
> of invalid XHTML in the pages output; things like
> – Element style does not carry attribute type
> – Value "auto" for attribute dir of span is not among the enumerated set
> – No declaration for attribute placeholder of element input
> – Syntax of value for attribute selected of option is not valid
> – No declaration for attribute primary of element a
> – No declaration for attribute context of element a
> – Value "search" for attribute type of input is not among the enumerated set
MediaWiki uses HTML5 going forwards. A lot of these 'bugs' look like
you're erroneously leaving $wgHtml5 on and expecting it to output XHTML.

> I’ll have to spot and fix them all.
>
> bye,
> //mirabilos

~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name]