[Pkg-mediawiki-devel] Fwd: Re: MediaWiki tarballs and the WMF

[Platonides]

On 11/06/12 10:42, Thorsten Glaser wrote:
> On Thu, 7 Jun 2012, Mark A. Hershberger wrote:
> 
>> I especially like the idea of an /etc/mediawiki.d config directory.
> 
> We have something like that in mediawiki-extensions-base,
> with a set of scripts (mwenext/mwdisext) similar to those
> shipped with Apache 2, so the sysadmin can manually enable
> (and disable again) extensions. I do not like the idea of
> having things forced unconditionally and believe the current
> infrastructure enough unless someone points out a good reason
> otherwise.

That seems equally good. It's just named
/etc/mediawiki-extensions/extensions-enabled/ instead of /etc/mediawiki.d

How are extensions there loaded?

Note:
http://anonscm.debian.org/viewvc/pkg-mediawiki/mediawiki-extensions/trunk/sbin/mwenext?view=markup
should also run update.php in case the new extension needs extra tables.


>> A supported release shouldn't need any patching...
> 
> There’s always distribution-specific patching, but yes, anything
> other than that should probably sent upstream. I’ve not been the
> best citizen with that always, especially due to bad experience
> with other projects.

Then that would lead to us having a bad experience with Debian :)



>> So yes, I'm happy we are improving collaboration packagers <-> upstream.
> 
> Agreed.
> 
> By the way, here™ we have more local patches; please tell me what you
> think about them (currently against 1.15):
(...)

> === added file 'debian/patches/tarent.patch'
> --- debian/patches/tarent.patch	1970-01-01 00:00:00 +0000
> +++ debian/patches/tarent.patch	2012-01-13 12:21:15 +0000
> @@ -0,0 +1,49 @@
> +Index: mediawiki-1.15.5/includes/DefaultSettings.php
> +===================================================================
> +--- mediawiki-1.15.5.orig/includes/DefaultSettings.php	2012-01-13 13:20:46.000000000 +0100
> ++++ mediawiki-1.15.5/includes/DefaultSettings.php	2012-01-13 13:21:12.000000000 +0100
> +@@ -280,6 +280,8 @@
> + 	'mailto:',
> + 	'news:',
> + 	'svn://',
> ++	'webdavs://',

This could be added without much problems. Although 'webdav://' seems a
candidate to add with it, too. Do you have a RFC number defining the
protocol?


> ++	'file:',
What's the advantage of using file://? Many browsers forbid file://
links from working.
I don't think it's appropiate to have by default.
If the wiki really needs them (eg. they use file:// to link to a shared
mount point), they can either add it themselves or install one of file
linking extensions:
http://www.mediawiki.org/wiki/Extension:FileLink
http://www.mediawiki.org/wiki/Extension:FileProtocolLinks


> +Index: mediawiki-1.15.5/includes/SearchPostgres.php
> +===================================================================
> +--- mediawiki-1.15.5.orig/includes/SearchPostgres.php	2009-01-13 21:28:54.000000000 +0100
> ++++ mediawiki-1.15.5/includes/SearchPostgres.php	2012-01-13 13:21:12.000000000 +0100
> +@@ -143,6 +143,12 @@
> + 		}
> + 		$prefix = $wgDBversion < 8.3 ? "'default'," : '';
> + 
> ++		/*-
> ++		 * tarent workaround / bugfix for
> ++		 * https://evolvis.org/tracker/t_follow.php/1031
> ++		 */
> ++		$prefix = "'default',";
> ++
> + 		# Get the SQL fragment for the given term
> + 		$searchstring = $this->parseQuery( $term );
> + 

I replied to the Support desk thread you opened:
 http://www.mediawiki.org/w/index.php?title=Thread:Project:Support_desk/PostgreSQL_and_the_database_search
the script you want is maintenance/rebuildtextindex.php

I'm unsure how it should be dealt with. I first thought the table should
be converted on upgrading MediaWiki. But the problem is not upgrading
MediaWiki, but postgresql.
Moreover, $wgDBversion will probably be autodetected, so we can't even
check for an existing $wgDBversion with an old value.
An unsuspecting user upgrading PostgreSQL would equally have the search
failure.
Do you know if there is a way to detect the format used by searchindex ?

Ccing Chad (author of r81132) and Greg.