[Pkg-mediawiki-devel] Fwd: Re: MediaWiki patches in Debian.

[Platonides]

Forwarding MaxSem reply on wikitech-l

-------- Original message --------
Subject: Re: MediaWiki patches in Debian.
From: Max Semenik <maxsem.wiki at gmail.com>

Ewww, some of this stuff is ugly.

On 11.06.2012, 16:42 Mark wrote:

> On 06/11/2012 04:42 AM, Thorsten Glaser wrote:
>> On Thu, 7 Jun 2012, Mark A. Hershberger wrote:
>>
>>> I especially like the idea of an /etc/mediawiki.d config directory.
>> We have something like that in mediawiki-extensions-base,
>> with a set of scripts (mwenext/mwdisext) similar to those
>> shipped with Apache 2, so the sysadmin can manually enable
>> (and disable again) extensions.

> Excellent.

>>> So yes, I'm happy we are improving collaboration packagers <-> upstream.
>> Agreed.

> In order to help this collaboration -- and in recognition of my own
> knowledge gaps when it comes to MW code -- I'm adding wikitech-l to the
> CC list. (Original message is here:
> http://lists.alioth.debian.org/pipermail/pkg-mediawiki-devel/2012-June/002008.html)

>> By the way, here™ we have more local patches; please tell me what you
>> think about them (currently against 1.15):
>>
>> === modified file 'debian/changelog'
>> --- debian/changelog  2012-05-30 14:51:27 +0000
>> +++ debian/changelog  2012-05-30 14:52:41 +0000
>> @@ -1,3 +1,17 @@
>> +mediawiki (1:1.15.5-10tarent1) unstable; urgency=low
>> +
>> +  [ Thorsten Glaser ]
>> +  * debian/patches/tarent.patch: new
>> +    - includes/specials/SpecialAllpages.php:
>> +      raise $maxPerPage, $maxLineCount

With a significant number of subpages available, this patch would
allow to DoS a wiki with simple F5 being constantly pressed.

>> +    - includes/DefaultSettings.php: add webdavs:// and file: support

Apparently, NEVER EDIT THIS FILE at the top of DefaultSettings is not
enough? All such changes kill people's ability to painlessly switch to
tarball in case they need something fresher than what packages can
give them. Or if packages are broken.

Also, I strongly doubt about these protocols' support across different
browsers and platforms (especially file:), which means more nice ways
to shoot yourself on the foot.

>> +  * debian/control: prefer PostgreSQL over MySQL in Depends/Recommends

PG is currently third DB in terms on MW support, significant number of
extensions don't support it. If we recommend MySQL for MW, pretty
please follow this recommendation, unless MySQL is seriously broken on
your distro.

> Could you help me understand the changes the rational for increasing
> maxPerPage and maxLineCount by two orders of magnitude?  Is there any
> benefit to showing 30,000 pages on an index sub-page?

Because someone wanted it and haven't thought about performance.