[Pkg-mediawiki-devel] Bug#694114: $wgLDAPAuthAttribute is broken in LDAP authentication extension 2.0a

[Patrick Näf]

On 26.11.2012 11:33, Thorsten Glaser wrote:
> On Sat, 24 Nov 2012, Patrick Näf wrote:
>
>> This is a bug that was introduced upstream at some time, but 
>> apparently has
>> been fixed in the meantime. A discussion related to the problem is 
>> here:
>> 
>> http://www.mediawiki.org/wiki/Extension_talk:LDAP_Authentication#LDAP_search_for_special_entry_12928.
>
> That link just points me to the talk page for the extension,
> i.e. the anchor seems to not exist.

Hm, let's try again, I hope this URL is more persistent:

http://www.mediawiki.org/w/index.php?title=Extension_talk:LDAP_Authentication&offset=20120814030149&limit=20#LDAP_search_for_special_entry_12928


The interesting parts (for me) of the discussion are
- The extension author's (Ryan's) response from 15 March 2012 where he 
confirms that the code is broken, but that it should be fixed in source 
control
- The response from 10 August 2012 where a user confirms that the code 
in source control (trunk) is fixed



>> I checked out the code of the current upstream release 2.0c, and it 
>> appears
>> that the implementation has indeed been fixed:
>> 
>> https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/LdapAuthentication.git;a=blob;f=LdapAuthentication.php;h=9cde1d82ff87abefdef5c02a430b70b505a61d98;hb=acabccab960e3243a4c627e84d336b114b970f26
>
> That’s a blob link, which is also not helpful. If you can point
> out a (or more) commit(s) to fix the problem, I can apply them
> locally to our package and upload that for testing by you.

This seems to be the commit that fixes the problem (commit message: 
"Reverting AuthAttribute back to former implementation."):

https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/LdapAuthentication.git;a=commitdiff;h=9ccef963bc825075db6d6b6458bdfde1ebcab6d1

I hope this is the appropriate URL for you. The page also has a "patch" 
link which should provide a downloadable patch that can - hopefully - be 
applied to the Debian package.


Thanks for looking into this
Patrick