[Pkg-mono-devel] libanculus-sharp review

Sun Jun 15 19:20:10 UTC 2008

On Sun, 15 Jun 2008 19:57:46 +0200, Mirco Bauer wrote:

> Hi David,
> 
> here a review of your imported libanculus-sharp source package.

Thanks. :)

> On Sun, 2008-06-15 at 17:16 +0000, hanska-guest at users.alioth.debian.org 
> wrote:
> > Added: packages/libanculus-sharp/trunk/debian/control
> > URL:
> > http://svn.debian.org/wsvn/pkg-cli-libs/packages/libanculus-sharp/trunk/debian/control?rev=3766&op=file
> > ==============================================================================
> > --- packages/libanculus-sharp/trunk/debian/control (added) +++
> > packages/libanculus-sharp/trunk/debian/control Sun Jun 15 17:16:52 2008 @@
> > -1,0 +1,44 @@ +Source: libanculus-sharp
> > +Section: libs
> > +Priority: optional
> > +Maintainer: Debian CLI Libraries Team
> > <pkg-cli-libs-team at lists.alioth.debian.org> +Uploaders: David Paleino
> > <d.paleino at gmail.com> +Build-Depends: debhelper (>= 6)
> > +Build-Depends-Indep: cli-common-dev (>= 0.4.4), autoconf, automake,
> > + monodoc-base, mono-gac, mono-gmcs, libmono-dev (>= 1.2.3), autotools-dev,
> > + libglib2.0-cil (>= 2.8.0), libgtk2.0-cil (>= 2.8.0),
> > libmono-winforms2.0-cil +Standards-Version: 3.8.0
> > +Homepage: http://libanculus-sharp.googlecode.com/
> > +Vcs-Svn:
> > svn://svn.debian.org/svn/collab-maint/deb-maint/libanculus-sharp/trunk
> > +Vcs-Browser:
> > http://svn.debian.org/wsvn/collab-maint/deb-maint/libanculus-sharp/trunk/ +
> > +Package: libanculus0.3.1-cil
> 
> This isn't the right package name, the policy says major+minor, not
> major+minor+micro.

Fixed :) (rev3773)

> > +Package: libanculus-sharp
> > +Architecture: all
> > +Depends: libanculus0.3.1-cil
> > +Description: dummy transitional package for libanculus0.3.1-cil
> > + This is a dummy package, to ease upgrades because of the renaming to
> > + libanculus0.3.1-cil.
> > + .
> > + Once you have libanculus0.3.1-cil installed, you can safely remove
> > + this package.
> > +
> 
> IMHO this transition package is overkill for a library that is not used
> by a single package in debian :) (I would drop it)

Done (rev3773)

> And where is the monodoc documentation package? Without it you are
> pretty clueless when developing an application using that library. As
> example check the webkit-sharp source package (its in pkg-cli-lib SVN
> repo).

Yes, I saw it.
I didn't add it just because I didn't know I would have to. The CLI Policy is
apparently missing this point :(.
I'll see webkit-sharp and act consequently, thanks.

> > Added: packages/libanculus-sharp/trunk/debian/copyright
> > URL:
> > http://svn.debian.org/wsvn/pkg-cli-libs/packages/libanculus-sharp/trunk/debian/copyright?rev=3766&op=file
> > ==============================================================================
> > --- packages/libanculus-sharp/trunk/debian/copyright (added) +++
> > packages/libanculus-sharp/trunk/debian/copyright Sun Jun 15 17:16:52 2008
> > @@ -1,0 +1,37 @@ +Source:
> > http://code.google.com/p/libanculus-sharp/downloads/list +
> > +Files: debian/*
> > +Copyright: Â© 2008, David Paleino <d.paleino at gmail.com>
> > +License: GPL-2+
> > + This package is free software; you can redistribute it and/or modify
> > + it under the terms of the GNU General Public License as published by
> > + the Free Software Foundation; either version 2 of the License, or
> > + (at your option) any later version.
> > [..]
> > +On Debian systems, the complete text of the GNU General
> > +Public License v2 can be found in `/usr/share/common-licenses/GPL-2'.
> 
> Inconsistency here, above it says GPL-2+ (notice the +), while this
> reference is for v2 only.

Uhm... another DD (for other packages) told me that if I use "GPL-2+", I should
point to ./GPL (which is GPL-3) -- is that right? I'm willing to use GPL-3+,
but can't really say if it's MIT-compatible (truly, I didn't check this at all).

However, this has been fixed (rev3774)

> > Added: packages/libanculus-sharp/trunk/debian/installcligac
> > URL:
> > http://svn.debian.org/wsvn/pkg-cli-libs/packages/libanculus-sharp/trunk/debian/installcligac?rev=3766&op=file
> > ==============================================================================
> > --- packages/libanculus-sharp/trunk/debian/installcligac (added) +++
> > packages/libanculus-sharp/trunk/debian/installcligac Sun Jun 15 17:16:52
> > 2008 @@ -1,0 +1,3 @@ +/usr/lib/libanculus-sharp/Anculus.Gui.dll
> > +/usr/lib/libanculus-sharp/Anculus.Core.dll
> > +/usr/lib/libanculus-sharp/Anculus.Core.Extended.dll
> > 
> 
> Wrong location, check 3.1.2 of the CLI policy.

Fixed this with a patch to *.pc.in files, and a quick hack in debian/rules
(rev3775)

> > Added: packages/libanculus-sharp/trunk/debian/links
> > URL:
> > http://svn.debian.org/wsvn/pkg-cli-libs/packages/libanculus-sharp/trunk/debian/links?rev=3766&op=file
> > ==============================================================================
> > --- packages/libanculus-sharp/trunk/debian/links (added) +++
> > packages/libanculus-sharp/trunk/debian/links Sun Jun 15 17:16:52 2008 @@
> > -1,0 +1,3 @@
> > +usr/lib/pkgconfig/anculus-core-extended-0.3.1.pc	/usr/lib/pkgconfig/anculus-core-extended.pc
> > +usr/lib/pkgconfig/anculus-core-0.3.1.pc				/usr/lib/pkgconfig/anculus-core.pc
> > +usr/lib/pkgconfig/anculus-gui-0.3.1.pc				/usr/lib/pkgconfig/anculus-gui.pc
> 
> Same here with the ABI version, see above (only major+minor instead of
> major+minor+micro).

Fixed in some of the revisions above.

> > Added: packages/libanculus-sharp/trunk/debian/rules
> > URL:
> > http://svn.debian.org/wsvn/pkg-cli-libs/packages/libanculus-sharp/trunk/debian/rules?rev=3766&op=file
> > ==============================================================================
> > [..]
> > +	find $(CURDIR) -name "*.dll" -exec chmod 644 {} \;
> 
> you should use dh_clifixperms instead.

I hope you mean in the binary target; done (rev3776)

> The debian/rules file would be much shorter and thus simpler and easier
> to maintain, if you use dh7 minimalistic style packaging, as example
> take a look at webkit-sharp.

I've never used that style, but I've also read the original post about it by
Joey (probably him, but I may be wrong) on -devel (?). I don't really like
"blackbox" solutions (i.e. where you don't see what is being done, like cdbs is
IMHO), and at a quick look on what you've done with webkit-sharp, it seems so
to me. But, I admit, I haven't looked at it with attention (nor I have done
`man dh`, which seems to be necessary, since it's used throughout the Makefile).
If it's not a problem, I prefer to keep it like it is. I've also set it back to
UNRELEASED, since I need to make the monodoc manual package, and I hope I have
time to read further on dh7 before asking again for a review :)

Thanks for your time,
David

-- 
 . ''`.  Debian maintainer | http://wiki.debian.org/DavidPaleino
 : :'  : Linuxer #334216 --|-- http://www.hanskalabs.net/
 `. `'`  GPG: 1392B174 ----|---- http://snipr.com/qa_page
   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-mono-devel/attachments/20080615/921fb85b/attachment.pgp 