[Pkg-mozext-commits] [firetray] 102/399: update README/TODO about disbabling newmailalerts for excluded accounts

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch dfsg-clean
in repository firetray.

commit 04c5f061423e6eefabc89d79e25050ebd5fad6e2
Author: foudfou <foudil.newbie+git at gmail.com>
Date:   Mon Nov 28 03:52:41 2011 +0100

    update README/TODO about disbabling newmailalerts for excluded accounts
---
 README.md                         |   10 ++++++++--
 TODO                              |   17 +++++++++++++----
 src/chrome/content/options.xul    |    5 ++---
 src/modules/FiretrayIconLinux.jsm |    2 +-
 src/modules/FiretrayMessaging.jsm |    2 ++
 5 files changed, 26 insertions(+), 10 deletions(-)

diff --git a/README.md b/README.md
index b88bc58..aabfc6b 100644
--- a/README.md
+++ b/README.md
@@ -30,8 +30,14 @@ KNOWN BUGS
 
 * windows aren't restored with the same z-order, but there is [no means to correct that under Linux](https://bugzilla.mozilla.org/show_bug.cgi?id=156333 "GetZOrderDOMWindowEnumerator is broken on Linux")
 
-* popup notifications can't be easily disabled along with excluded mail
-accounts, since newmailalerts are [hard-coded](http://mxr.mozilla.org/comm-central/find?string=content/newmailalert)
+* notifications for excluded mail account servers are not
+  disabled. Newmailalerts are
+  [hard-coded](http://mxr.mozilla.org/comm-central/find?string=content/newmailalert)
+  and we can't easily disable thme on a per-server basis (only globally, see
+  `mail.biff.show_alert`). The proper way would probably be to disable default
+  notifications globally, and handle notifications ourselves. This is out of
+  the scope of this addon, but you may want to give a try to the
+  [MailAlert extension](https://addons.mozilla.org/en-US/thunderbird/addon/mailbox-alert/)
 
 Acknowledgment
 --------------
diff --git a/TODO b/TODO
index 09d4f6b..1182f09 100644
--- a/TODO
+++ b/TODO
@@ -1,15 +1,23 @@
-=TODO=
+TODO
+----
 
 * convert to a https://developer.mozilla.org/en/Extensions/Bootstrapped_extensions
 
 see ../restartless-restart-ffext/ and
 http://erikvold.com/blog/index.cfm/2010/10/28/restartless-firefox-addons-part-1-giving-your-addon-the-bootstrap
 
-=WONTFIX=
+WONTFIX
+-------
 
 * ability to hide windows individually/globally
 
-=ROADMAP=
+* disable notifications for excluded mail account servers. NOTE: toggle
+  `login_at_startup` and `check_new_mail` is a bad idea. Mainly because the
+  user may be toggling them after we store the previous values (and before we
+  restore them)
+
+ROADMAP
+-------
 
 * Mozilla products have entered a
   [rapid release cycle](http://blog.mozilla.com/blog/2011/04/13/new-channels-for-firefox-rapid-releases/
@@ -22,7 +30,8 @@ http://erikvold.com/blog/index.cfm/2010/10/28/restartless-firefox-addons-part-1-
 * the Firetray project plans to replace the binary-based version with the js-types version when enough features are covered
 * meanwhile, Firetray users are invited to switch to the preview release of the js-ctypes version [link to beta channel] and [provide feedback](https://github.com/foudfou/FireTray/issues) as to what important features are missing
 
-==NEXT FEATURES==
+NEXT FEATURES
+-------------
 
 * mouse scrolls on tray icon hides/shows
 * hide to tray on minimize
diff --git a/src/chrome/content/options.xul b/src/chrome/content/options.xul
index c9f9349..8308bba 100644
--- a/src/chrome/content/options.xul
+++ b/src/chrome/content/options.xul
@@ -116,11 +116,10 @@
 
             <tree id="ui_tree_mail_accounts" flex="1" rows="10" minwidth="400"
                   seltype="single" editable="true" hidecolumnpicker="false"
+                  observes="broadcaster-notification-disabled"
                   preference-editable="true"
                   preference="pref_string_mail_accounts"
-                  onsynctopreference="return
-                                      firetray.UIOptions.saveTreeAccountsOrServerTypes();"
-                  observes="broadcaster-notification-disabled">
+                  onsynctopreference="return firetray.UIOptions.saveTreeAccountsOrServerTypes();">
               <treecols>
                 <treecol id="account_or_server_type_name" editable="false" flex="2"
                          persist="width" primary="true" label="&account_or_server_type_name;"
diff --git a/src/modules/FiretrayIconLinux.jsm b/src/modules/FiretrayIconLinux.jsm
index 38c77a3..04334cf 100644
--- a/src/modules/FiretrayIconLinux.jsm
+++ b/src/modules/FiretrayIconLinux.jsm
@@ -282,7 +282,7 @@ firetray.Handler.setTooltipDefault = function() {
 };
 
 firetray.Handler.setText = function(text, color) { // TODO: split into smaller functions;
-  LOG("setText");
+  LOG("setText, color="+color);
   if (typeof(text) != "string")
     throw new TypeError();
 
diff --git a/src/modules/FiretrayMessaging.jsm b/src/modules/FiretrayMessaging.jsm
index ea79e5b..bcdae8e 100644
--- a/src/modules/FiretrayMessaging.jsm
+++ b/src/modules/FiretrayMessaging.jsm
@@ -86,6 +86,7 @@ firetray.Messaging = {
       return;
 
     let mailAccounts = firetray.Utils.getObjPref('mail_accounts');
+    LOG("mail accounts from pref: "+JSON.stringify(mailAccounts));
     let serverTypes = mailAccounts["serverTypes"];
     let excludedAccounts = mailAccounts["excludedAccounts"];
     let excludedFoldersFlags = firetray.Utils.prefService
@@ -95,6 +96,7 @@ firetray.Messaging = {
     try {
       let accounts = new this.Accounts();
       for (let accountServer in accounts) {
+        LOG("is servertype excluded: "+serverTypes[accountServer.type].excluded+", account exclusion index: "+excludedAccounts.indexOf(accountServer.key));
         if ( (serverTypes[accountServer.type].excluded)
           || (excludedAccounts.indexOf(accountServer.key) >= 0) )
           continue;

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/firetray.git