[Pkg-mozext-commits] [firetray] 133/399: better for loops

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch dfsg-clean
in repository firetray.

commit 4c3a1cfc89ba3428b6d2ff50790e8911d2bb5b79
Author: foudfou <foudil.newbie+git at gmail.com>
Date:   Sat Jan 7 22:16:17 2012 +0100

    better for loops
    
    http://stackoverflow.com/questions/5349425/whats-the-fastest-way-to-loop-through-an-array-in-javascript
---
 src/chrome/content/options.js       |   18 +++++++++---------
 src/modules/FiretrayMessaging.jsm   |    4 ++--
 src/modules/gtk2/FiretrayWindow.jsm |    2 +-
 3 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/src/chrome/content/options.js b/src/chrome/content/options.js
index 14bae55..735ee24 100644
--- a/src/chrome/content/options.js
+++ b/src/chrome/content/options.js
@@ -35,7 +35,7 @@ var firetrayUIOptions = {
     // NOTE: not sure this is necessary on window close
     let tree = document.getElementById("ui_tree_mail_accounts");
     let that = this;
-    for (let i=0; i < tree.view.rowCount; i++) {
+    for (let i=0, len=tree.view.rowCount; i<len ; ++i) {
       let cells = tree.view.getItemAtIndex(i).getElementsByTagName("treecell");
       if (tree.view.getLevel(i) === TREELEVEL_SERVER_TYPES) {
         // account_or_server_type_excluded, account_or_server_type_order
@@ -57,7 +57,7 @@ var firetrayUIOptions = {
 
   disableGroup: function(group, disableval) {
     try {
-      for(var i=0; i< group.childNodes.length; i++)
+      for (let i=0, len=group.childNodes.length; i<len ; ++i)
         group.childNodes[i].disabled = disableval;
     } catch(e) {}
   },
@@ -144,7 +144,7 @@ var firetrayUIOptions = {
 
     let prefExcludedFoldersFlags = firetray.Utils.prefService
       .getIntPref("excluded_folders_flags");
-    for(let folderType in FLDRS_UNINTERESTING) {
+    for (let folderType in FLDRS_UNINTERESTING) {
       let localizedFolderType = this.strings.getString(folderType);
       let item = excludedFoldersList.appendItem(localizedFolderType, folderType);
       item.setAttribute("observes", "broadcaster-notification-disabled");
@@ -159,7 +159,7 @@ var firetrayUIOptions = {
 
     LOG("LAST SELECTED: "+excludedFoldersList.currentItem.label);
     let excludedFoldersFlags = null;
-    for(let i = 0; i < excludedFoldersList.itemCount; i++) {
+    for (let i = 0, len=excludedFoldersList.itemCount; i<len; ++i) {
       let folder = excludedFoldersList.getItemAtIndex(i);
       if (folder.selected)
         excludedFoldersFlags &= ~FLDRS_UNINTERESTING[folder.value];
@@ -182,7 +182,7 @@ var firetrayUIOptions = {
     try {
       let cells = row.childNodes; // .getElementsByTagName('treecell');
       LOG("CELLS: "+cells);
-      for (let i=0; i< cells.length; i++) {
+      for (let i=0, len=cells.length; i<len; ++i) {
         LOG("i: "+i+", cell:"+cells[i]);
         if (disable === true) {
           cells[i].setAttribute('properties', "disabled");
@@ -226,7 +226,7 @@ var firetrayUIOptions = {
         checkboxCell,
         'ancestor::xul:treeitem[1]/descendant::xul:treechildren//xul:treerow');
       LOG("subRows="+subRows);
-      for (let i=0; i<subRows.length; i++) {
+      for (let i=0, len=subRows.length; i<len; ++i) {
         firetrayUIOptions._disableTreeRow(
           subRows[i], (checkboxCell.getAttribute("value") === "false"));
       }
@@ -267,7 +267,7 @@ var firetrayUIOptions = {
     LOG("serverTypesSorted: "+serverTypesSorted);
 
     let target = document.getElementById("ui_mail_accounts");
-    for (let i=0; i<serverTypesSorted.length; i++) {
+    for (let i=0, len=serverTypesSorted.length; i<len; ++i) {
       let serverTypeName = serverTypesSorted[i];
 
       let item = document.createElement('treeitem');
@@ -307,7 +307,7 @@ var firetrayUIOptions = {
         continue;
 
       let rowDisabled = (cellExcluded.getAttribute("value") === "false");
-      for (let i=0; i<typeAccounts.length; i++) {
+      for (let i=0, len=typeAccounts.length; i<len; ++i) {
         let subItem = document.createElement('treeitem');
         let subRow = document.createElement('treerow');
 
@@ -363,7 +363,7 @@ var firetrayUIOptions = {
 
     LOG("VIEW="+ tree.view + ", rowCount="+tree.view.rowCount);
     let prefObj = {"serverTypes":{}, "excludedAccounts":[]};
-    for (let i=0; i < tree.view.rowCount; i++) {
+    for (let i=0, len=tree.view.rowCount; i<len; ++i) {
       let accountOrServerTypeName = tree.view.getCellText(
         i, tree.columns.getNamedColumn("account_or_server_type_name"));
       let accountOrServerTypeExcluded = (
diff --git a/src/modules/FiretrayMessaging.jsm b/src/modules/FiretrayMessaging.jsm
index b982aa3..3f4d3f8 100644
--- a/src/modules/FiretrayMessaging.jsm
+++ b/src/modules/FiretrayMessaging.jsm
@@ -178,7 +178,7 @@ firetray.Messaging.Accounts.prototype.__iterator__ = function() {
    (nsISupportsArray, nsICollection). Should be OK to re-build a JS-Array for
    few accounts */
   let accountServers = [];
-  for (let i = 0; i < accounts.Count(); i++) {
+  for (let i=0, len=accounts.Count(); i<len; ++i) {
     let account = accounts.QueryElementAt(i, Ci.nsIMsgAccount);
     let accountServer = account.incomingServer;
     accountServers[i] = accountServer;
@@ -202,7 +202,7 @@ firetray.Messaging.Accounts.prototype.__iterator__ = function() {
     });
   }
 
-  for (i = 0; i < accountServers.length; i++) {
+  for (let i=0, len=accountServers.length; i<len; ++i) {
     LOG("ACCOUNT: "+accountServers[i].prettyName+" type: "+accountServers[i].type);
     yield accountServers[i];
   }
diff --git a/src/modules/gtk2/FiretrayWindow.jsm b/src/modules/gtk2/FiretrayWindow.jsm
index 25ed1b9..88b117e 100644
--- a/src/modules/gtk2/FiretrayWindow.jsm
+++ b/src/modules/gtk2/FiretrayWindow.jsm
@@ -269,7 +269,7 @@ firetray.Window = {
     if (!propsFound) return 0;
 
     let maximizedHorz = maximizedVert = false;
-    for (let i=0, propsFoundLen=nitems.value; i<propsFoundLen; ++i) {
+    for (let i=0, len=nitems.value; i<len; ++i) {
       LOG("i: "+propsFound.contents[i]);
       let foundProp = propsFound.contents[i].toString();
       if (strEquals(propsFound.contents[i], x11.current.Atoms['_NET_WM_STATE_HIDDEN']))

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/firetray.git