[Pkg-mozext-commits] [firetray] 201/399: document why browser.tabs.warnOnClose set to false

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch dfsg-clean
in repository firetray.

commit c6be061070fc4a3d35aac0b61dd91908b632452d
Author: foudfou <foudil.newbie+git at gmail.com>
Date:   Thu Mar 8 23:40:26 2012 +0100

    document why browser.tabs.warnOnClose set to false
---
 src/chrome/content/overlay.js |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/chrome/content/overlay.js b/src/chrome/content/overlay.js
index 49d8766..6b86b3a 100644
--- a/src/chrome/content/overlay.js
+++ b/src/chrome/content/overlay.js
@@ -42,7 +42,11 @@ var firetrayChrome = { // each new window gets a new firetrayChrome !
     firetray.LOG('Firetray UNLOADED !');
   },
 
-  // TODO: prevent preceding warning about closing multiple tabs (browser.tabs.warnOnClose)
+  /* until we find a fix (TODO), we need to set browser.tabs.warnOnClose=false
+   to prevent the popup when closing a window with multiple tabs and when
+   hides_on_close is set (we are not actually closing the tabs!). There is no
+   use trying to set warnOnClose=false temporarily in onClose, since onClose is
+   called *after* the popup */
   onClose: function(event) {
     firetray.LOG('Firetray CLOSE');
     let win = event.originalTarget;

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/firetray.git