[Pkg-mozext-commits] [firetray] 178/399: actually fix new message count update when biff becomes false

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch dfsg-clean
in repository firetray.

commit ca9496d3e3a86843c52656e26c4c785b9dcfbd9e
Author: foudfou <foudil.newbie+git at gmail.com>
Date:   Wed Feb 15 00:00:00 2012 +0100

    actually fix new message count update when biff becomes false
    
    Looks like a Thunderbird bug: on an Imap folder, when switching to another
    folder, that is after having visited that folder, "OnItemBoolPropertyChanged
    NewMessages for folder Inbox was true became false" ...but getNumNewMessages
    still returns 1 (?!)
---
 src/modules/FiretrayMessaging.jsm |   15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/src/modules/FiretrayMessaging.jsm b/src/modules/FiretrayMessaging.jsm
index 5fa6ca5..0fcac42 100644
--- a/src/modules/FiretrayMessaging.jsm
+++ b/src/modules/FiretrayMessaging.jsm
@@ -54,20 +54,23 @@ firetray.Messaging = {
    */
   mailSessionListener: {
     notificationFlags:
+      // Ci.nsIFolderListener.propertyChanged |
+      // Ci.nsIFolderListener.propertyFlagChanged |
+      // Ci.nsIFolderListener.event |
       Ci.nsIFolderListener.intPropertyChanged |
-      Ci.nsIFolderListener.boolPropertyChanged, // all
+      Ci.nsIFolderListener.boolPropertyChanged,
 
     OnItemPropertyChanged: function(item, property, oldValue, newValue) { // NumNewBiffMessages
-      LOG("OnItemPropertyChanged "+property+" for folder "+item.prettyName+" was "+oldValue+" became "+newValue);
+      LOG("OnItemPropertyChanged "+property+" for folder "+item.prettyName+" was "+oldValue+" became "+newValue+" NEW MESSAGES="+item.getNumNewMessages(true));
     },
 
     OnItemIntPropertyChanged: function(item, property, oldValue, newValue) { // TotalUnreadMessages, BiffState
-      LOG("OnItemIntPropertyChanged "+property+" for folder "+item.prettyName+" was "+oldValue+" became "+newValue);
+      LOG("OnItemIntPropertyChanged "+property+" for folder "+item.prettyName+" was "+oldValue+" became "+newValue+" NEW MESSAGES="+item.getNumNewMessages(true));
       this.updateMsgCount(item, property, oldValue, newValue);
     },
 
     OnItemBoolPropertyChanged: function(item, property, oldValue, newValue) { // NewMessages
-      LOG("OnItemBoolPropertyChanged "+property+" for folder "+item.prettyName+" was "+oldValue+" became "+newValue);
+      LOG("OnItemBoolPropertyChanged "+property+" for folder "+item.prettyName+" was "+oldValue+" became "+newValue+" NEW MESSAGES="+item.getNumNewMessages(true));
       this.updateMsgCount(item, property, oldValue, newValue);
     },
 
@@ -90,7 +93,9 @@ firetray.Messaging = {
             prop === "TotalUnreadMessages" ||
             msgCountType === FIRETRAY_MESSAGE_COUNT_TYPE_NEW &&
             prop === "NewMessages") {
-            firetray.Messaging.updateMsgCount();
+          if (oldValue === true && newValue === false)
+            item.setNumNewMessages(0);
+          firetray.Messaging.updateMsgCount();
         }
       }
     }

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/firetray.git