[Pkg-mozext-commits] [firetray] 62/399: remove mail server type definition checks

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch dfsg-clean
in repository firetray.

commit 2c25e98d9a60a4dc3192f3100cce907dbb0c2e24
Author: foudfou <foudil.newbie+git at gmail.com>
Date:   Tue Sep 27 01:47:20 2011 +0200

    remove mail server type definition checks
---
 src/modules/FiretrayMessaging.jsm |   12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/src/modules/FiretrayMessaging.jsm b/src/modules/FiretrayMessaging.jsm
index 5138752..81a4f61 100644
--- a/src/modules/FiretrayMessaging.jsm
+++ b/src/modules/FiretrayMessaging.jsm
@@ -31,6 +31,9 @@ if ("undefined" == typeof(firetray)) {
 
 firetray.Messaging = {
   // TODO: turn into pref.
+  /* NOTE: definition checks not implemented on purpose (performance mainly)
+   should be well defined in default prefs, and new types are unlikely to
+   appear soon. */
   SERVER_TYPES: {
     "pop3": { order: 1, excluded: false },
     "imap": { order: 1, excluded: false },
@@ -166,15 +169,6 @@ firetray.Messaging.Accounts.prototype.__iterator__ = function() {
   for (let i = 0; i < accounts.Count(); i++) {
     let account = accounts.QueryElementAt(i, Ci.nsIMsgAccount);
     let accountServer = account.incomingServer;
-
-    // checks
-    if (typeof(firetray.Messaging.SERVER_TYPES[accountServer.type]) === "undefined")
-      throw "mail server type for '"+accountServer.prettyName+"' not defined";
-    if (typeof(firetray.Messaging.SERVER_TYPES[accountServer.type].order) === "undefined")
-      throw "mail server type for '"+accountServer.prettyName+"' missing 'order' definition";
-    if (typeof(firetray.Messaging.SERVER_TYPES[accountServer.type].excluded) === "undefined")
-      throw "mail server type for '"+accountServer.prettyName+"' missing 'excluded' definition";
-
     accountServers[i] = accountServer;
   }
 

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/firetray.git