[Pkg-mozext-commits] [perspectives-extension] 07/72: new preferences should be created in the "extensions.perspectives.x" namespace

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch master
in repository perspectives-extension.

commit d6984e57b37acd9fa0f3a9635f34cb4891f6e516
Author: Gerold Meisinger <gerold.meisinger at gmail.com>
Date:   Sun Jun 15 19:05:39 2014 +0100

    new preferences should be created in the "extensions.perspectives.x" namespace
---
 plugin/chrome/content/notaries.js            | 6 +++---
 plugin/chrome/content/preferences_dialog.xul | 4 ++--
 plugin/defaults/preferences/prefs.js         | 7 +++++--
 3 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/plugin/chrome/content/notaries.js b/plugin/chrome/content/notaries.js
index ed618ec..1acd50a 100644
--- a/plugin/chrome/content/notaries.js
+++ b/plugin/chrome/content/notaries.js
@@ -265,7 +265,7 @@ var Perspectives = {
 
 		ti.timeout_id = window.setTimeout(function() {
 			Perspectives.notaryQueryTimeout(ti,0);
-		}, Perspectives.root_prefs.getIntPref("perspectives.query_timeout_ms") );
+		}, Perspectives.root_prefs.getIntPref("extensions.perspectives.query_timeout_ms") );
 	},
 
 	querySingleNotary: function(notary_server, ti) {
@@ -313,7 +313,7 @@ var Perspectives = {
 					}
 				}
 
-				var is_final_timeout = (num_timeouts == Perspectives.root_prefs.getIntPref("perspectives.query_retries"));
+				var is_final_timeout = (num_timeouts == Perspectives.root_prefs.getIntPref("extensions.perspectives.query_retries"));
 				if(is_final_timeout) {
 					// time is up, so just add empty results for missing
 					// notaries and begin processing results
@@ -334,7 +334,7 @@ var Perspectives = {
 
 					ti.timeout_id = window.setTimeout(function() {
 						Perspectives.notaryQueryTimeout(ti, num_timeouts + 1);
-					}, Perspectives.root_prefs.getIntPref("perspectives.query_timeout_ms") );
+					}, Perspectives.root_prefs.getIntPref("extensions.perspectives.query_timeout_ms") );
 				}
 
 			} catch (e) {
diff --git a/plugin/chrome/content/preferences_dialog.xul b/plugin/chrome/content/preferences_dialog.xul
index 13b1e77..87c6d06 100644
--- a/plugin/chrome/content/preferences_dialog.xul
+++ b/plugin/chrome/content/preferences_dialog.xul
@@ -21,11 +21,11 @@
     type="int"/>
   <preference
     id="query-retries"
-    name="perspectives.query_retries"
+    name="extensions.perspectives.query_retries"
     type="int"/>
   <preference
     id="query-timeout"
-    name="perspectives.query_timeout_ms"
+    name="extensions.perspectives.query_timeout_ms"
     type="int"/>
   <preference
     id="security-settings"
diff --git a/plugin/defaults/preferences/prefs.js b/plugin/defaults/preferences/prefs.js
index 68bc0e3..788a306 100755
--- a/plugin/defaults/preferences/prefs.js
+++ b/plugin/defaults/preferences/prefs.js
@@ -1,7 +1,10 @@
+// new preference should be created in the "extensions.perspectives.x" namespace
+// see https://developer.mozilla.org/en/Extensions/Extension_etiquette
+// and https://github.com/danwent/Perspectives/issues/59
 pref("perspectives.quorum_thresh"    ,   75);
 pref("perspectives.required_duration",    0);
-pref("perspectives.query_retries"    ,    2);
-pref("perspectives.query_timeout_ms" , 5000);
+pref("extensions.perspectives.query_retries"   ,    2);
+pref("extensions.perspectives.query_timeout_ms", 5000);
 pref("perspectives.security_settings",    1);
 pref("perspectives.exceptions.permanent", false);
 pref("perspectives.exceptions.enabled", true);

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/perspectives-extension.git