[Pkg-mozext-commits] [perspectives-extension] 02/22: Perspectives - Fix text display for insecure content

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch debian
in repository perspectives-extension.

commit 74909228cf0db9e12b8595acb18e3ca6ea24245c
Author: Dave Schaefer <dave.schaefer at gmail.com>
Date:   Thu Jan 30 23:47:37 2014 -0700

    Perspectives - Fix text display for insecure content
    
    Same as before, the tooltip was not getting set, causing the UI to show 'null'.
---
 plugin/chrome/content/notaries.js | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/plugin/chrome/content/notaries.js b/plugin/chrome/content/notaries.js
index b66c36a..40ab5f1 100644
--- a/plugin/chrome/content/notaries.js
+++ b/plugin/chrome/content/notaries.js
@@ -705,8 +705,13 @@ var Perspectives = {
 				// just does not show positive security indicators.  
 				if(mixed_security) { 
 					// FIXME: need to clear any contrary banners
-					Pers_statusbar.setStatus(ti.uri, Pers_statusbar.STATE_NEUT, 
-					"HTTPS Certificate is trusted, but site contains insecure embedded content. "); //TODO: localize
+					// TODO: once we have separated calculation of results
+					// from applying the resuts and can add better tests for these,
+					// wrap setting the status and the tooltip in their own function
+					// so no steps are forgotten
+					ti.query_results.tooltip =
+						"HTTPS Certificate is trusted, but site contains insecure embedded content.";
+					Pers_statusbar.setStatus(ti.uri, Pers_statusbar.STATE_NEUT, ti.query_results.tooltip); //TODO: localize
 					// this will flicker, as we can't rely on just doing it on 'firstLook'
 					// due to Firefox oddness
 					if(ti.override_used) { 	

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/perspectives-extension.git