[Pkg-mozext-commits] [adblock-plus] 43/464: Use system() call consistently to invoke external applications, also don't store directory entries when creating JAR files.

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch master
in repository adblock-plus.

commit b3755aa982d9205d46f7dba547b773402d17cfd3
Author: Wladimir Palant <trev at adblockplus.org>
Date:   Sun Jul 5 09:00:18 2009 +0200

    Use system() call consistently to invoke external applications, also don't store directory entries when creating JAR files.
---
 Packager.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Packager.pm b/Packager.pm
index 6ec597a..613ea52 100644
--- a/Packager.pm
+++ b/Packager.pm
@@ -263,7 +263,7 @@ sub makeJAR
 
   chdir('tmp');
   $self->fixLocales();
-  print `zip -rX0 $jarFile @include`;
+  system('zip', '-rXD0', $jarFile, @include);
   chdir('..');
 
   rename("tmp/$jarFile", "$jarFile");
@@ -436,7 +436,7 @@ sub makeXPI
   }
 
   chdir('tmp');
-  print `zip -rDX9 ../temp_xpi_file.xpi @files`;
+  system('zip', '-rDX9', '../temp_xpi_file.xpi', @files);
   chdir('..');
 
   $self->fixZipPermissions("temp_xpi_file.xpi") if $^O =~ /Win32/i;

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/adblock-plus.git