[Pkg-mozext-commits] [firebug] 07/82: Expand FBTest for 4233 to accommodate issue 6135

Mon Mar 31 22:45:36 UTC 2014

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to tag fbtest-1.11.2
in repository firebug.

commit 595703fd72b50daf57d113dc689c996a73761641
Author: Simon Lindholm <simon.lindholm10 at gmail.com>
Date:   Wed Dec 19 17:52:30 2012 +0100

    Expand FBTest for 4233 to accommodate issue 6135
---
 tests/content/console/completion/4233/issue4233.html | 3 +++
 tests/content/console/completion/4233/issue4233.js   | 5 ++++-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/tests/content/console/completion/4233/issue4233.html b/tests/content/console/completion/4233/issue4233.html
index 3f21daf..39d1105 100644
--- a/tests/content/console/completion/4233/issue4233.html
+++ b/tests/content/console/completion/4233/issue4233.html
@@ -6,6 +6,7 @@
 <script>
 var htmlCollection = document.getElementsByTagName("html");
 var anArray = [1,2,3,4];
+var objWithNumericProps = {"0": 0, "1": 1};
 </script>
 </head>
 <body>
@@ -59,6 +60,8 @@ that completions appear for:</li>
     <li><code style="color:green">getterSeemingEval('[window]')[0].i</code></li>
     <li><code style="color:green">String.prototype.ch</code></li>
     <li><code style="color:green">new Date().g</code></li>
+    <li><code style="color:green">anArray["0</code></li>
+    <li><code style="color:green">objWithNumericProps.0</code></li>
 </ul>
 
 and don't appear for:
diff --git a/tests/content/console/completion/4233/issue4233.js b/tests/content/console/completion/4233/issue4233.js
index 8bfe174..76df74e 100644
--- a/tests/content/console/completion/4233/issue4233.js
+++ b/tests/content/console/completion/4233/issue4233.js
@@ -18,8 +18,9 @@ function runTest()
                 cmdLine.focus();
                 cmdLine.value = expr.slice(0, -1);
                 FBTest.synthesizeKey(expr.slice(-1), null, win);
+                FBTest.synthesizeKey("VK_TAB", null, win);
 
-                var hasCompletion = (completionBox.value.length > expr.length);
+                var hasCompletion = (completionBox.value.length <= expr.length);
                 FBTest.compare(shouldComplete, hasCompletion,
                     "Completions should " + (shouldComplete ? "" : "not ") +
                     "appear for: " + expr);
@@ -90,7 +91,9 @@ function runTest()
                 ["new Date().g", true],
 
                 ["anArray.0", false],
+                ["anArray[\"0", true],
                 ["htmlCollection.0", false],
+                ["objWithNumericProps.0", true],
 
                 // currently not handled
                 ["(window).i", false],

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/firebug.git

