[Pkg-mozext-commits] [firebug] 09/82: FBTest: Do not use 'for each' in a test driver

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to tag fbtest-1.11.2
in repository firebug.

commit ef350b84ea03f7683efcef9fac80f6387f031583
Author: Jan Odvarko <odvarko at gmail.com>
Date:   Wed Jan 2 13:59:10 2013 +0100

    FBTest: Do not use 'for each' in a test driver
---
 tests/content/css/1189/issue1189.js | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/tests/content/css/1189/issue1189.js b/tests/content/css/1189/issue1189.js
index ff031d0..87c0714 100644
--- a/tests/content/css/1189/issue1189.js
+++ b/tests/content/css/1189/issue1189.js
@@ -13,6 +13,7 @@ function runTest()
         {
             shorthandPropOverwritesShorthandProp(panel, callback);
         });
+
         tests.push(function(callback)
         {
             shorthandPropOverwritesSingleValueProp(panel, callback);
@@ -43,16 +44,19 @@ function checkProp(panel, element, checkedSelector, checkedPropName, callback)
     FBTest.selectElementInHtmlPanel(element, function(node)
     {
         var rules = panel.panelNode.getElementsByClassName("cssRule");
-        for each (var rule in rules)
+        for (var j=0; j<rules.length; j++)
         {
+            var rule = rules[j];
             var selector = rule.getElementsByClassName("cssSelector").item(0).textContent;
             if (selector == checkedSelector)
             {
                 var props = rule.getElementsByClassName("cssProp");
-                for each (var prop in props)
+                for (var i=0; i<props.length; i++)
                 {
+                    var prop = props[i];
                     var propName = prop.getElementsByClassName("cssPropName").item(0).
                         textContent;
+
                     if (propName == checkedPropName)
                     {
                         FBTest.ok(FW.FBL.hasClass(prop, "cssOverridden"),

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/firebug.git