[Pkg-mozext-commits] [firebug] 51/82: Issue 6183: Closure Inspector: some variables are treated as DOM properties

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to tag fbtest-1.11.2
in repository firebug.

commit b4da1035b1c9394f6cfe5b21bfb620ed3cce93a9
Author: Simon Lindholm <simon.lindholm10 at gmail.com>
Date:   Sun Jan 13 01:28:45 2013 +0100

    Issue 6183: Closure Inspector: some variables are treated as DOM properties
    
    http://code.google.com/p/fbug/issues/detail?id=6183
---
 extension/content/firebug/lib/dom.js | 44 +++---------------------------------
 1 file changed, 3 insertions(+), 41 deletions(-)

diff --git a/extension/content/firebug/lib/dom.js b/extension/content/firebug/lib/dom.js
index 5ef7852..72ea5fe 100644
--- a/extension/content/firebug/lib/dom.js
+++ b/extension/content/firebug/lib/dom.js
@@ -812,14 +812,15 @@ Dom.getDOMMembers = function(object)
         { return domMemberCache.Node; }
     else if (object instanceof Event || object instanceof Dom.EventCopy)
         { return domMemberCache.Event; }
-    else if (object instanceof Object)
-        { return domMemberCache.Object; }
 
     return null;
 };
 
 Dom.isDOMMember = function(object, propName)
 {
+    // We use "in" here instead of "hasOwnProperty" so that things on Object.prototype
+    // also get treated as DOM members.
+    // XXXsimon: Non-DOM objects should also get this behavior.
     var members = Dom.getDOMMembers(object);
     return members && propName in members;
 };
@@ -1165,45 +1166,6 @@ domMemberMap.Window =
     "getDefaultComputedStyle"
 ];
 
-domMemberMap.Object =
-[
-    "arguments",
-    "caller",
-    "length",
-    "name",
-    "__defineGetter__",
-    "__defineSetter__",
-    "__lookupGetter__",
-    "__lookupSetter__",
-    "apply",
-    "bind",
-    "call",
-    "constructor",
-    "create",
-    "defineProperties",
-    "defineProperty",
-    "freeze",
-    "getOwnPropertyDescriptor",
-    "getOwnPropertyNames",
-    "getPrototypeOf",
-    "hasOwnProperty",
-    "isExtensible",
-    "isFrozen",
-    "isGenerator",
-    "isPrototypeOf",
-    "isSealed",
-    "keys",
-    "preventExtensions",
-    "propertyIsEnumerable",
-    "seal",
-    "toLocaleString",
-    "toSource",
-    "toString",
-    "unwatch",
-    "valueOf",
-    "watch"
-];
-
 domMemberMap.Location =
 [
     "href",

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/firebug.git