[Pkg-mozext-commits] [firebug] 60/82: Issue 6128: U+202E (RTL character) messes up the source code

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to tag fbtest-1.11.2
in repository firebug.

commit 3cd3085d18f57908513dac1fe0b7ca8af78114c7
Author: Simon Lindholm <simon.lindholm10 at gmail.com>
Date:   Tue Dec 11 21:33:28 2012 +0100

    Issue 6128: U+202E (RTL character) messes up the source code
    
    http://code.google.com/p/fbug/issues/detail?id=6128
---
 extension/content/firebug/lib/css.js    | 17 +++++++++--------
 extension/content/firebug/lib/string.js |  6 ++++--
 2 files changed, 13 insertions(+), 10 deletions(-)

diff --git a/extension/content/firebug/lib/css.js b/extension/content/firebug/lib/css.js
index d1f449c..2f5da52 100644
--- a/extension/content/firebug/lib/css.js
+++ b/extension/content/firebug/lib/css.js
@@ -239,14 +239,15 @@ Css.copyBoxStyles = function(fromNode, toNode, style)
         if (!style)
             style = view.getComputedStyle(fromNode, "");
 
-        toNode.style.marginTop = style.getPropertyCSSValue("margin-top").cssText;
-        toNode.style.marginRight = style.getPropertyCSSValue("margin-right").cssText;
-        toNode.style.marginBottom = style.getPropertyCSSValue("margin-bottom").cssText;
-        toNode.style.marginLeft = style.getPropertyCSSValue("margin-left").cssText;
-        toNode.style.borderTopWidth = style.getPropertyCSSValue("border-top-width").cssText;
-        toNode.style.borderRightWidth = style.getPropertyCSSValue("border-right-width").cssText;
-        toNode.style.borderBottomWidth = style.getPropertyCSSValue("border-bottom-width").cssText;
-        toNode.style.borderLeftWidth = style.getPropertyCSSValue("border-left-width").cssText;
+        toNode.style.marginTop = style.marginTop;
+        toNode.style.marginRight = style.marginRight;
+        toNode.style.marginBottom = style.marginBottom;
+        toNode.style.marginLeft = style.marginLeft;
+        toNode.style.borderTopWidth = style.borderTopWidth;
+        toNode.style.borderRightWidth = style.borderRightWidth;
+        toNode.style.borderBottomWidth = style.borderBottomWidth;
+        toNode.style.borderLeftWidth = style.borderLeftWidth;
+        toNode.style.unicodeBidi = style.unicodeBidi;
 
         return style;
     }
diff --git a/extension/content/firebug/lib/string.js b/extension/content/firebug/lib/string.js
index c638a18..b82d517 100644
--- a/extension/content/firebug/lib/string.js
+++ b/extension/content/firebug/lib/string.js
@@ -110,6 +110,8 @@ e(0xfeff, "#65279", attr, text, white, editor); // ZERO WIDTH NO-BREAK SPACE
 e(0x200d, "zwj", attr, text, white, editor);
 e(0x200e, "lrm", attr, text, white, editor);
 e(0x200f, "rlm", attr, text, white, editor);
+e(0x202d, "#8237", attr, text, white, editor); // left-to-right override
+e(0x202e, "#8238", attr, text, white, editor); // right-to-left override
 
 // ********************************************************************************************* //
 // Entity escaping
@@ -360,9 +362,9 @@ function unescapeEntities(str, lists)
 // String escaping
 
 var escapeForTextNode = Str.escapeForTextNode = createSimpleEscape("text", "normal");
-var escapeForHtmlEditor = Str.escapeForHtmlEditor = createSimpleEscape("editor", "normal");
 var escapeForElementAttribute = Str.escapeForElementAttribute = createSimpleEscape("attributes", "normal");
-var escapeForCss = Str.escapeForCss = createSimpleEscape("css", "normal");
+Str.escapeForHtmlEditor = createSimpleEscape("editor", "normal");
+Str.escapeForCss = createSimpleEscape("css", "normal");
 
 // deprecated compatibility functions
 Str.deprecateEscapeHTML = createSimpleEscape("text", "normal");

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/firebug.git