[Pkg-mozext-commits] [firebug] 39/68: Issue 6304: XHR Spy never finishes in Firefox 19

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to tag fbtest-1.11.4
in repository firebug.

commit be4fbaf07d588ef20aa8864d1cc2a446818c4b05
Author: Jan Odvarko <odvarko at gmail.com>
Date:   Fri Mar 1 09:16:32 2013 +0100

    Issue 6304: 	XHR Spy never finishes in Firefox 19
---
 extension/content/firebug/net/spy.js | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/extension/content/firebug/net/spy.js b/extension/content/firebug/net/spy.js
index 38a48a0..05fbed5 100644
--- a/extension/content/firebug/net/spy.js
+++ b/extension/content/firebug/net/spy.js
@@ -45,6 +45,10 @@ var contexts = [];
 
 var redirectionLimit = Options.getPref("network.http", "redirection-limit");
 
+var versionChecker = Xpcom.CCSV("@mozilla.org/xpcom/version-comparator;1", "nsIVersionComparator");
+var appInfo = Xpcom.CCSV("@mozilla.org/xre/app-info;1", "nsIXULAppInfo");
+var fx20 = versionChecker.compare(appInfo.version, "20") >= 0;
+
 // ********************************************************************************************* //
 // Spy Module
 
@@ -763,7 +767,8 @@ function onHTTPSpyReadyStateChange(spy, event)
     // (onreadystatechange) for another request. In such case we need to quickly detach our
     // Spy object. New one will be immediatelly created when HTTP-ON-OPENING-REQUEST is fired.
     // See issue 5049
-    if (spy.xhrRequest.readyState == 1)
+    // This approach doesn't work in Firefox 19 (see issue 6304) so, let's enable it for 20+ only.
+    if (spy.xhrRequest.readyState == 1 && fx20)
     {
         if (FBTrace.DBG_SPY)
         {

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/firebug.git