[Pkg-mozext-commits] [firebug] 09/15: Issue 5978: Firebug does not show javascript from iframes.

David Prévot taffit at moszumanska.debian.org
Mon Mar 31 22:46:38 UTC 2014


This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to tag firebug-1.10.5
in repository firebug.

commit 7227fc862207d0c5645d876a83c80a6054c06e20
Author: Jan Odvarko <odvarko at gmail.com>
Date:   Fri Oct 12 16:06:02 2012 +0200

     Issue 5978: 	Firebug does not show javascript from iframes.
---
 extension/content/firebug/chrome/window.js | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/extension/content/firebug/chrome/window.js b/extension/content/firebug/chrome/window.js
index 5759451..1a97330 100644
--- a/extension/content/firebug/chrome/window.js
+++ b/extension/content/firebug/chrome/window.js
@@ -101,9 +101,17 @@ Win.getRootWindow = function(win)
 {
     for (; win; win = win.parent)
     {
-        if (!win.parent || win == win.parent || !(win.parent instanceof win.Window) )
+        if (!win.parent || win == win.parent)
+            return win;
+
+        // When checking the 'win.parent' type we need to use the target
+        // type from the same scope. i.e. from win.parent
+        // Iframes from different domains can use different Window type than
+        // the top level window.
+        if (!(win.parent instanceof win.parent.Window))
             return win;
     }
+
     return null;
 };
 

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/firebug.git



More information about the Pkg-mozext-commits mailing list