[Pkg-mozext-commits] [gcontactsync] 11/17: Issue #53: Improve Postbox support, hid the gContactSync tab until it is implemented

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch master
in repository gcontactsync.

commit 133f0603332340f5f9cf6305be13df3863c37a16
Author: Josh Geenen <joshgeenen at gmail.com>
Date:   Sun Oct 26 13:58:33 2014 -0500

    Issue #53: Improve Postbox support, hid the gContactSync tab until it is implemented
---
 src/content/CardDialogOverlay.js | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/src/content/CardDialogOverlay.js b/src/content/CardDialogOverlay.js
index 75bfca4..2527e02 100644
--- a/src/content/CardDialogOverlay.js
+++ b/src/content/CardDialogOverlay.js
@@ -78,6 +78,8 @@ com.gContactSync.CardDialogOverlay = {
   mLoadNumber: 0,
   /** This stores whether the contact is read-only (ie from LDAP or the Mac AB) */
   mDisabled:   false,
+  /** Whether the application is Postbox */
+  mIsPostbox:  false,
   /**
    * Adds a tab to the tab box, if possible.  Waits until the abCardOverlay is
    * loaded.
@@ -118,8 +120,9 @@ com.gContactSync.CardDialogOverlay = {
     }
     // add the email type drop down menus
     try {
+      this.mIsPostbox = this.addPostboxEmailType(document.getElementById("PrimaryEmail"));
       // add the type for Postbox (this does nothing for TB or Seamonkey)
-      if (!this.addPostboxEmailType(document.getElementById("PrimaryEmail"))) {
+      if (!this.mIsPostbox) {
         var emailTypes       = com.gContactSync.gdata.contacts.EMAIL_TYPES,
             primaryEmailBox  = this.getBox("PrimaryEmail"),
             secondEmailBox   = this.getBox("SecondEmail"),
@@ -138,6 +141,11 @@ com.gContactSync.CardDialogOverlay = {
     catch (ex0) {
       com.gContactSync.alertError("Unable to setup email types: " + ex0);
     }
+    // Hide the gContactSync tab for Postbox
+    // TODO - implement full support for Postbox instead.
+    if (this.mIsPostbox) {
+      document.getElementById("gContactSyncTab").collapsed = true;
+    }
     var newDialog      = false, // post-Mailnews Core Bug 63941 - TODO - can this be removed (Postbox?)
         showPhoneTypes = com.gContactSync.Preferences.mSyncPrefs.phoneTypes.value,
         swap           = com.gContactSync.Preferences.mSyncPrefs.swapMobilePager.value,

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/gcontactsync.git