[Pkg-mozext-commits] [adblock-plus] 07/28: Issue 1241 - Element hiding exceptions broken in Firefox 34

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch master
in repository adblock-plus.

commit 356f198f908b713912303e3bd7dea59c609f8907
Author: Wladimir Palant <trev at adblockplus.org>
Date:   Mon Aug 18 12:54:09 2014 +0200

    Issue 1241 - Element hiding exceptions broken in Firefox 34
    
    --HG--
    extra : amend_source : 3c71d4dc80658b66a1cbcb11e34058b9ccf435ae
---
 lib/elemHideHitRegistration.js | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/lib/elemHideHitRegistration.js b/lib/elemHideHitRegistration.js
index a05f6df..791130b 100644
--- a/lib/elemHideHitRegistration.js
+++ b/lib/elemHideHitRegistration.js
@@ -126,7 +126,11 @@ HitRegistrationChannel.prototype = {
   {
     let {Policy} = require("contentPolicy");
     let {ElemHide} = require("elemHide");
-    let data = "<bindings xmlns='http://www.mozilla.org/xbl'><binding id='dummy'/></bindings>";
+
+    // This dummy binding below won't have any effect on the element. For
+    // elements that should be hidden however we don't return any binding at
+    // all, this makes Gecko stop constructing the node - it cannot be shown.
+    let data = "<bindings xmlns='http://www.mozilla.org/xbl'><binding id='dummy' bindToUntrustedContent='true'/></bindings>";
     let filter = ElemHide.getFilterByKey(this.key);
     if (filter)
     {

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/adblock-plus.git