[Pkg-mozext-commits] [automatic-save-folder] 51/133: Change : - Leave the matching row colored if highlighted, and set a border to see it as selected instead of removing the color. Fix : - English locale

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch wip
in repository automatic-save-folder.

commit 740ffa0031b882a878367ffd899b3f8ae8b5ce46
Author: Cyan <Cyan at d0063192-6b2e-11de-89a9-0b20f3e2dceb>
Date:   Sun Jan 31 17:43:26 2010 +0000

    Change :
    - Leave the matching row colored if highlighted, and set a border to see it
      as selected instead of removing the color.
    Fix :
    - English locale
    
    git-svn-id: http://automatic-save-folder.googlecode.com/svn/trunk@51 d0063192-6b2e-11de-89a9-0b20f3e2dceb
---
 content/asf.js              | 16 +++++++++++++---
 defaults/preferences/asf.js |  2 +-
 locale/en-US/about.dtd      |  2 +-
 skin/style.css              | 14 ++++++++++++++
 4 files changed, 29 insertions(+), 5 deletions(-)

diff --git a/content/asf.js b/content/asf.js
index 3ff33ae..7c81f9d 100644
--- a/content/asf.js
+++ b/content/asf.js
@@ -191,6 +191,7 @@ var automatic_save_folder = {
 			moveUpButton.disabled   = true;
 			moveUpButton.image = "chrome://asf/skin/up_disabled.png";
 		}
+		this.set_row_color();
 	},
 
 
@@ -253,12 +254,20 @@ var automatic_save_folder = {
 				}
 			}
 			
-			// enable this to remove the color of the selected item (but works only with mouse-click, not keyboard arrows)
-			if(tree.currentIndex > -1)
+			// enable this to set black border to the selected colored row
+			if((tree.currentIndex > -1) && (tree.view.getItemAtIndex(tree.currentIndex).firstChild.hasAttribute('properties')) )
 			{
 				currentitem = tree.view.getItemAtIndex(tree.currentIndex);
-				currentitem.firstChild.removeAttribute('properties');
+				color = currentitem.firstChild.getAttribute('properties');
+				if (color == "FilterTestPass") currentitem.firstChild.setAttribute('properties', "FilterTestPassSelected"); 
+				if (color == "FilterTestFail") currentitem.firstChild.setAttribute('properties', "FilterTestFailSelected"); 
 			}
+			// enable this to remove the color of the selected item
+			// if((tree.currentIndex > -1) && (tree.view.getItemAtIndex(tree.currentIndex).firstChild.hasAttribute('properties')) )
+			// {
+				// currentitem = tree.view.getItemAtIndex(tree.currentIndex);
+				// currentitem.firstChild.removeAttribute('properties');
+			// }
 		}
 	},
 
@@ -565,6 +574,7 @@ var automatic_save_folder = {
 			}
 		}
 		
+		idx = tree.currentIndex;
 		tree.treeBoxObject.ensureRowIsVisible(idx);
 		
 		//autosave when moving filters
diff --git a/defaults/preferences/asf.js b/defaults/preferences/asf.js
index 136de7f..5f2a664 100644
--- a/defaults/preferences/asf.js
+++ b/defaults/preferences/asf.js
@@ -12,7 +12,7 @@
 // See http://kb.mozillazine.org/Localize_extension_descriptions
 pref("extensions.asf at mangaheart.org.description", "chrome://asf/locale/asf.properties");
 // See http://developer.mozilla.org/En/Download_Manager_preferences   or    http://kb.mozillazine.org/About:config_entries
-// it make automatic saving to the right folder - 0= desktop, 1= system download dir, 2= user define
+// it makes automatic saving to the right folder - 0= desktop, 1= system download dir, 2= user define
 // does only affect the user if useDownloadDir = true  ---- if "always ask the destination folder" is selected in FF options, it has no effect on the user.
  pref("browser.download.folderList", 2);
  pref("extensions.asf.dialogaccept", false);
diff --git a/locale/en-US/about.dtd b/locale/en-US/about.dtd
index 68fe3b8..741a429 100644
--- a/locale/en-US/about.dtd
+++ b/locale/en-US/about.dtd
@@ -44,7 +44,7 @@
 * Separated the "informations" tab in two other tabs "Help" and "About...".
 * Added tooltips instead of help text bellow each options (has some issues with Firefox2).
 * On the download dialog, disable the suggested folders if the "What should Firefox do with this file?" group's option is not set to "Save File"
-* Added a drop-down menu on the Add&Edit window for quick access to the folders already added from the available filter's list.
+* Added a drop-down menu on the Add&Edit window for quick access to the folders already added from the available filter's list.
 ! Correct links to Mozilla website, which were forced to the French page.
 ! Correct the filter's checking when Dynamic folder creation is enabled
 ! Prevent an exception when "use current website URL" option is enabled and the address bar doesn't contain an URL.
diff --git a/skin/style.css b/skin/style.css
index ddb07e0..6d13d5f 100644
--- a/skin/style.css
+++ b/skin/style.css
@@ -22,4 +22,18 @@ treechildren::-moz-tree-row(FilterTestPass)
 treechildren::-moz-tree-row(FilterTestFail)
 {
   background-color: #F9CBCB;
+}
+
+treechildren::-moz-tree-row(FilterTestPassSelected)
+{
+  background-color: #CDFFB5;
+  border: solid 1px #000000;
+  color: #000000;
+}
+
+treechildren::-moz-tree-row(FilterTestFailSelected)
+{
+  background-color: #F9CBCB;
+  border: solid 1px #000000;
+  color: #000000;
 }
\ No newline at end of file

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/automatic-save-folder.git