[Pkg-mozext-commits] [tabmixplus] 60/107: Workaround for bug 1157404 - [e10s] Possible to end up with two visuallyselected="true" tabs at the same time Backed out changeset fd2318e8513b fixed: Tabmix scrolls my tab bar when opening new tab, see commit message for changeset 680efec2e71c

David Prévot taffit at moszumanska.debian.org
Tue Dec 29 19:02:50 UTC 2015


This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch master
in repository tabmixplus.

commit e577d64dd21afcf8eef84899087e6752970ceceb
Author: onemen <tabmix.onemen at gmail.com>
Date:   Sun Nov 8 22:00:32 2015 +0200

    Workaround for bug 1157404 - [e10s] Possible to end up with two visuallyselected="true" tabs at the same time
    Backed out changeset fd2318e8513b fixed: Tabmix scrolls my tab bar when opening new tab, see commit message for changeset 680efec2e71c
---
 chrome/content/links/userInterface.js | 14 +++++++-------
 chrome/content/tabmix.js              |  8 ++++++++
 2 files changed, 15 insertions(+), 7 deletions(-)

diff --git a/chrome/content/links/userInterface.js b/chrome/content/links/userInterface.js
index eaf5783..21aca0d 100644
--- a/chrome/content/links/userInterface.js
+++ b/chrome/content/links/userInterface.js
@@ -176,13 +176,6 @@ function TMP_BrowserOpenTab(aTab, replaceLastTab) {
     }
   }
 
-  // make sure to update recently used tabs
-  // if user open many tabs quickly select event don't have time to fire
-  // before new tab select
-  if (!loadInBackground) {
-    gBrowser.selectedTab = newTab;
-    TMP_LastTab.PushSelectedTab();
-  }
   if (aTab && aTab.localName == "tab")
     gBrowser.moveTabTo(newTab, aTab._tPos + 1);
   else if (!replaceLastTab && Tabmix.prefs.getBoolPref("openNewTabNext")) {
@@ -190,6 +183,13 @@ function TMP_BrowserOpenTab(aTab, replaceLastTab) {
     // and it mess with recently used tabs order
     gBrowser.moveTabTo(newTab, selectedTab._tPos + 1);
   }
+  // make sure to update recently used tabs
+  // if user open many tabs quickly select event don't have time to fire
+  // before new tab select
+  if (!loadInBackground) {
+    gBrowser.selectedTab = newTab;
+    TMP_LastTab.PushSelectedTab();
+  }
 
   gBrowser.selectedBrowser.focus();
   // focus the address bar on new tab
diff --git a/chrome/content/tabmix.js b/chrome/content/tabmix.js
index 507fd95..3db92cf 100644
--- a/chrome/content/tabmix.js
+++ b/chrome/content/tabmix.js
@@ -956,6 +956,14 @@ var TMP_eventListener = {
     TabmixSessionManager.tabMoved(tab, aEvent.detail, tab._tPos);
 
     TabmixTabbar.updateBeforeAndAfter();
+
+    // Workaround for bug 115740, moveTabTo always set current tab
+    // visuallySelected to true
+    if (Tabmix.isVersion(390) && gBrowser._switcher &&
+        gBrowser._switcher.visibleTab != gBrowser.selectedTab) {
+      gBrowser._switcher.visibleTab._visuallySelected = true;
+      gBrowser.selectedTab._visuallySelected = false;
+    }
   },
 
   onTabUnpinned: function TMP_EL_onTabUnpinned(aEvent) {

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/tabmixplus.git



More information about the Pkg-mozext-commits mailing list