[Pkg-mozext-commits] [tabmixplus] 05/51: Make sure we clean clickOnCurrent attribute from non-selected tab (see changeset fb96279e9504)

Mon Feb 2 18:36:45 UTC 2015

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch master
in repository tabmixplus.

commit 24955670553496afe00380edda795c2b7bd230ab
Author: onemen <tabmix.onemen at gmail.com>
Date:   Tue Dec 30 21:17:05 2014 +0200

    Make sure we clean clickOnCurrent attribute from non-selected tab (see changeset fb96279e9504)
---
 chrome/content/tab/tabbrowser_4.xml | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/chrome/content/tab/tabbrowser_4.xml b/chrome/content/tab/tabbrowser_4.xml
index 527b039..4b6fcfc 100644
--- a/chrome/content/tab/tabbrowser_4.xml
+++ b/chrome/content/tab/tabbrowser_4.xml
@@ -263,12 +263,14 @@
     <method name="onMouseCommand">
       <parameter name="aEvent"/>
       <body><![CDATA[
-        if ( this == this.parentNode.selectedItem ) {
-          if (aEvent.detail == 1)
-            this.setAttribute("clickOnCurrent","true");
-        }
+        let isSelected = this == this.parentNode.selectedItem;
+        Tabmix.setItem(this, "clickOnCurrent",
+                       isSelected && aEvent.detail == 1 || null);
+        if (isSelected)
+          return;
+
         // don't allow mouse click/down with modifiers to select tab
-        else if (aEvent.shiftKey || aEvent.ctrlKey || aEvent.altKey || aEvent.metaKey)
+        if (aEvent.shiftKey || aEvent.ctrlKey || aEvent.altKey || aEvent.metaKey)
           aEvent.stopPropagation();
         else {
           this.parentNode._selectNewTab(this);

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/tabmixplus.git

