[Pkg-mozext-commits] [gcontactsync] 22/31: Improved OAuth2 logging

David Prévot taffit at moszumanska.debian.org
Sun Feb 22 21:34:37 UTC 2015


This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch master
in repository gcontactsync.

commit c0fce61dc5d508dfde65e8f3c519cff0d0d9a98c
Author: Josh Geenen <joshgeenen at gmail.com>
Date:   Wed Dec 24 08:24:12 2014 -0600

    Improved OAuth2 logging
---
 src/content/AccountSetupWizard.js | 4 +++-
 src/content/OAuth2.js             | 5 +++--
 src/content/gdata.js              | 4 +++-
 3 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/src/content/AccountSetupWizard.js b/src/content/AccountSetupWizard.js
index d8d5581..ccd160e 100644
--- a/src/content/AccountSetupWizard.js
+++ b/src/content/AccountSetupWizard.js
@@ -127,7 +127,9 @@ com.gContactSync.AccountSetupWizard = {
 
     var wizard = document.getElementById("newAccountWizard");
     var browser = document.getElementById("browser");
-    browser.loadURI(com.gContactSync.gdata.getOAuthURL(this.mEmailAddress));
+    var url = com.gContactSync.gdata.getOAuthURL(this.mEmailAddress);
+    com.gContactSync.LOGGER.VERBOSE_LOG("Opening browser with URL: " + url);
+    browser.loadURI(url);
     com.gContactSync.OAuth2.init(browser, com.gContactSync.gdata.REDIRECT_URI, this.onSuccessfulAuthentication);
     wizard.canAdvance = false;
   },
diff --git a/src/content/OAuth2.js b/src/content/OAuth2.js
index abf04e1..53bb2ae 100644
--- a/src/content/OAuth2.js
+++ b/src/content/OAuth2.js
@@ -65,7 +65,7 @@ com.gContactSync.OAuth2 = {
    * @param aCode {string} The authorization code.
    */
   onCodeReceived: function OAuth2_onCodeReceived(aCode) {
-    com.gContactSync.LOGGER.LOG("Received an authorization code");
+    com.gContactSync.LOGGER.LOG("Received an authorization code: " + aCode);
     this.mBrowserElem.removeProgressListener(com.gContactSync.OAuth2.mListener);
     this.mBrowserElem.loadURI("");
     var request = new com.gContactSync.GHttpRequest("TOKEN_REQUEST", aCode);
@@ -81,7 +81,7 @@ com.gContactSync.OAuth2 = {
    * @param aHttpReq {XmlHttpRequest} The HTTP request.
    */
   onTokenReceived: function OAuth2_onTokenReceived(aHttpReq) {
-    com.gContactSync.LOGGER.LOG("Received an access token");
+    com.gContactSync.LOGGER.LOG("Received an access token + " + aHttpReq.responseText);
     com.gContactSync.OAuth2.mCallback(JSON.parse(aHttpReq.responseText));
   },
   /**
@@ -100,6 +100,7 @@ com.gContactSync.OAuth2 = {
      * @param aLocation The location.
      */
     onLocationChange: function (aWebProgress, aRequest, aLocation) {
+      com.gContactSync.LOGGER.LOG("Observed a location change: " + aLocation.spec);
       if (aLocation.spec.indexOf(com.gContactSync.OAuth2.mRedirectURI) === 0) {
         var code = com.gContactSync.parseURLParameters(aLocation.spec).code;
         com.gContactSync.OAuth2.onCodeReceived(code);
diff --git a/src/content/gdata.js b/src/content/gdata.js
index 63f221b..95859ac 100644
--- a/src/content/gdata.js
+++ b/src/content/gdata.js
@@ -468,7 +468,9 @@ com.gContactSync.gdata = {
     // when the setup window loads, set its onunload property to begin a sync
     wizard.addEventListener("load", function onloadListener() {
       var browser = wizard.document.getElementById("browser");
-      browser.loadURI(com.gContactSync.gdata.getOAuthURL(aEmail));
+      var url = com.gContactSync.gdata.getOAuthURL(aEmail);
+      com.gContactSync.LOGGER.VERBOSE_LOG("Opening browser with URL: " + url);
+      browser.loadURI(url);
       com.gContactSync.OAuth2.init(browser, com.gContactSync.gdata.REDIRECT_URI, function callback(aResponse) {
         wizard.close();
         aCallback(aResponse);

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/gcontactsync.git



More information about the Pkg-mozext-commits mailing list