[Pkg-mozext-commits] [itsalltext] 25/459: Fixed a lint error Changed the way releases work, so that I won't make stupid mistakes

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch master
in repository itsalltext.

commit 417c972b555c628748c0bfee59eb1fadadfc79bd
Author: Christian Höltje <docwhat at gerf.org>
Date:   Sat Dec 16 11:30:59 2006 -0500

    Fixed a lint error
    Changed the way releases work, so that I won't make stupid mistakes
---
 Makefile                     | 18 +++++++++++++-----
 chrome/content/itsalltext.js | 30 ++++++++++++++++++++++++++++--
 2 files changed, 41 insertions(+), 7 deletions(-)

diff --git a/Makefile b/Makefile
index ddc3d88..c888280 100644
--- a/Makefile
+++ b/Makefile
@@ -30,7 +30,7 @@ SOURCES=$(shell find . \
 VERSION=$(shell grep '<em:version>' install.rdf| perl -p -e 's!.*<em:version>\s*([^<]*)\s*</em:version>.*!$$1!;')
 SOURCES_JS=$(shell echo "$(SOURCES)" | xargs -n 1 echo | grep -E '\.js$$')
 
-XPI_FILE=../itsalltext.xpi
+XPI_FILE=../itsalltext-$(VERSION).xpi
 
 ifeq ($(VERBOSE),1)
 	Q =
@@ -38,11 +38,15 @@ else
 	Q = @
 endif
 
-all: jslint docs xpi
+all: jslint docs
 	$(Q)echo done
 
-.PHONY: xpi
-xpi: jslint $(XPI_FILE)
+.PHONY: release
+release: jslint version_check $(XPI_FILE)
+
+.PHONY: version_check
+version_check:
+	$(Q)echo "Version is $(VERSION)"
 
 %.xpi: $(SOURCES)
 	$(Q)echo Creating $@ ...
@@ -80,4 +84,8 @@ narf:
 
 .PHONY: clean
 clean:
-	$(Q)rm -rf $(XPI_FILE) *.log docs
+	$(Q)rm -rf $(XPI_FILE) *.log
+
+.PHONY: realclean
+realclean: clean
+	$(Q)rm -rf ../itsalltext*.xpi docs
diff --git a/chrome/content/itsalltext.js b/chrome/content/itsalltext.js
index 3a049e3..fccea36 100644
--- a/chrome/content/itsalltext.js
+++ b/chrome/content/itsalltext.js
@@ -57,13 +57,27 @@ function hashString(some_string) {
 }
 
 function ItsAllTextOverlay() {
-  /* This data is all private, which prevents security problems and it
+  /**
+   * This data is all private, which prevents security problems and it
    * prevents clutter and collection.
+   * @type Object
    */
   var that = this;
+  /**
+   * This holds a cache of all the textareas that we are watching.
+   * @type Hash
+   */
   var cache = {};
+  /**
+   * Keeps track of all the refreshes we are running.
+   * @type Array
+   */
   var cron = [null]; // Eat the 0th position
 
+  /**
+   * A constant, a string used for things like the preferences.
+   * @type String
+   */
   var MYSTRING = 'itsalltext';
 
   /**
@@ -79,6 +93,11 @@ function ItsAllTextOverlay() {
     consoleService.logStringMessage("ItsAllTextOverlay: " + args.join(' '));
   };
 
+  /**
+   * Displays debug information, if debugging is turned on.
+   * Requires Firebug.
+   * @param Object message One or more objects can be passed in to display.
+   */
   that.debug = function() {
     if (that.preferences.data.debug) {
       try { return Firebug.Console.logFormatted(arguments); } 
@@ -93,6 +112,10 @@ function ItsAllTextOverlay() {
     return obj;
   };
 
+  /**
+   * Returns the directory where we put files to edit.
+   * @returns nsILocalFile The location where we should write editable files.
+   */
   that.getEditDir = function() {
     /* Where is the directory that we use. */
     var fobj = Components.classes["@mozilla.org/file/directory_service;1"].
@@ -109,6 +132,9 @@ function ItsAllTextOverlay() {
     return fobj;
   };
 
+  /**
+   * Cleans out the edit directory, deleting all files.
+   */
   that.cleanEditDir = function() {
     var fobj = that.getEditDir();
     //return dir.directoryEntries;
@@ -233,7 +259,7 @@ function ItsAllTextOverlay() {
    */
   that.getDebug = function() {
     return that.preferences.data.debug;
-  }
+  };
 
   /**
    * A Cache object is used to manage the node and the file behind it.

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/itsalltext.git