[Pkg-mozext-commits] [itsalltext] 127/459: * better layout for the preferences, Yay!

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch master
in repository itsalltext.

commit a1d2e66dc406babdfd8d55a855282886d9a0ba83
Author: Christian Höltje <docwhat at gerf.org>
Date:   Sun Feb 11 20:45:03 2007 -0500

    * better layout for the preferences, Yay!
---
 chrome/content/newextension.xul | 15 ++++++--
 chrome/content/preferences.js   | 11 +++---
 chrome/content/preferences.xul  | 80 +++++++++++++++++++++++++----------------
 3 files changed, 65 insertions(+), 41 deletions(-)

diff --git a/chrome/content/newextension.xul b/chrome/content/newextension.xul
index 684f797..9df3951 100644
--- a/chrome/content/newextension.xul
+++ b/chrome/content/newextension.xul
@@ -10,10 +10,19 @@
 
   <script type="application/x-javascript" src="chrome://itsalltext/content/newextension.js"/>
   <grid>
-    <columns><column/><column/></columns>
+    <columns>
+      <column/>
+      <column/>
+    </columns>
     <rows>
-      <row align="center"><label value="Extension (with leading dot):"/><textbox id="new_ext" value=".txt"/></row>
-      <row align="center"><spacer/><checkbox id="do_save" label="Save for future use"/></row>
+      <row align="center">
+        <label value="Extension (with leading dot):"/>
+        <textbox id="new_ext" value=".txt"/>
+      </row>
+      <row align="center">
+        <spacer/>
+        <checkbox id="do_save" label="Save for future use"/>
+      </row>
     </rows>
   </grid>
 </dialog>
diff --git a/chrome/content/preferences.js b/chrome/content/preferences.js
index 4f0a035..5153c94 100644
--- a/chrome/content/preferences.js
+++ b/chrome/content/preferences.js
@@ -1,6 +1,4 @@
 // @todo [6] [pref] Better strategy for getting the default editor: EDITOR env variable or view_source.editor.path
-// @todo [3] [pref] Preference dialog redesign
-// @todo [1] [pref] [bug] The help text seems to be wrong a lot.
 /**
  * Open a filepicker to select the value of the editor.
  */
@@ -55,11 +53,10 @@ function pref_onload() {
         while (box.firstChild) {
             box.removeChild(box.firstChild);
         }
-        var desc, textnode;
-        desc = document.createElement('description');
-        textnode = document.createTextNode(["I was unable to run your editor, '",
-                                            editor.value,
-                                            "'.  Use the browse button to choose another editor and try again. "].join(''));
+        var desc = document.createElement('description');
+        var textnode = document.createTextNode(["I was unable to run your editor, '",
+                                                editor.value,
+                                                "'.  Use the browse button to choose another editor and try again. "].join(''));
         desc.appendChild(textnode);
         desc.style.maxWidth = '18em';
         box.appendChild(desc);
diff --git a/chrome/content/preferences.xul b/chrome/content/preferences.xul
index efc6936..0a6daf7 100644
--- a/chrome/content/preferences.xul
+++ b/chrome/content/preferences.xul
@@ -22,37 +22,55 @@
                 name="extensions.itsalltext.debug" type="bool"/>
   </preferences>
 
-  <hbox flex="1">
-    <vbox flex="1"> 
-      <hbox align="right">
-        <label control="editor" value="Editor: "/>
-        <textbox preference="pref_editor" id="editor" size="20" readonly="false"
-         style="-moz-appearance: none !important; background: inherit;" />
-        <button oncommand="pref_editor_select();" label="Browse" id="browse"
-        accesskey="b" tabindex="1"/>
-      </hbox>
-      <hbox align="right">
-        <label control="seconds" value="Seconds between refreshing: "/>
-        <textbox preference="pref_seconds" id="seconds" size="2"
-        maxlength="2" tabindex="2"/>
-      </hbox>
-      <hbox align="right">
-        <label control="charset"
-               value="Character Set (default: UTF-8): "/>
-        <textbox preference="pref_charset" id="charset" size="8" tabindex="3"/>
-      </hbox>
-      <hbox align="right">
-        <label control="charset"
-               value="File Extensions: "/>
-        <textbox preference="pref_extensions" id="extensions" size="30" tabindex="4"/>
-      </hbox>
-      <hbox align="right">
-        <label control="debug"
-               value="Enable Debugging: "/>
-        <checkbox preference="pref_debug" id="debug" tabindex="5"/>
-      </hbox>
-      <spacer flex="2"/>
-    </vbox>
+  <hbox>
+    <grid>
+      <columns>
+        <column/>
+        <column/>
+      </columns>
+      <rows>
+        <row align="center">
+          <label control="editor" value="Editor:"/>
+          <vbox>
+            <textbox preference="pref_editor" id="editor" size="20" readonly="false"
+             style="-moz-appearance: none !important; background:
+             inherit;" />
+            <hbox align="right">
+              <spacer/>
+              <button oncommand="pref_editor_select();" label="Browse"
+              id="browse" accesskey="b" tabindex="1"/>
+            </hbox>
+          </vbox>
+        </row>
+        <row align="center">
+          <label control="seconds" value="Seconds between refreshing:"/>
+          <hbox>
+            <textbox preference="pref_seconds" id="seconds" size="2"
+            maxlength="2" tabindex="2"/>
+            <spacer/>
+          </hbox>
+        </row>
+        <row align="center">
+          <label control="charset"
+                 value="Character Set (default: UTF-8):"/>
+          <hbox>
+            <textbox preference="pref_charset" id="charset" size="8" tabindex="3"/>
+            <spacer/>
+          </hbox>
+        </row>
+        <row align="center">
+          <label control="charset"
+                 value="File Extensions:"/>
+          <textbox preference="pref_extensions" id="extensions" size="30" tabindex="4"/>
+        </row>
+        <row align="center">
+          <label control="debug"
+                 value="Debugging:"/>
+          <checkbox preference="pref_debug" id="debug" tabindex="5"
+          label="Remove all bugs"/>
+        </row>
+      </rows>
+    </grid>
     <vbox id="help" flex="1">
     </vbox>
   </hbox>

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/itsalltext.git