[Pkg-mozext-commits] [itsalltext] 183/459: Minor cleanups to the bad editor stuff.

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch master
in repository itsalltext.

commit 4cdc8ada9e27a65a6f22293b934a4c2f8b250b7a
Author: Christian Höltje <docwhat at gerf.org>
Date:   Sun Apr 1 12:23:14 2007 -0400

    Minor cleanups to the bad editor stuff.
---
 chrome/content/badeditor.js              | 2 +-
 chrome/content/cacheobj.js               | 5 ++---
 chrome/locale/en-US/badeditor.dtd        | 4 ++--
 chrome/locale/en-US/badeditor.properties | 2 ++
 4 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/chrome/content/badeditor.js b/chrome/content/badeditor.js
index 28af752..32eb415 100644
--- a/chrome/content/badeditor.js
+++ b/chrome/content/badeditor.js
@@ -12,7 +12,7 @@ function doOnload() {
     var params = window['arguments'][0];
     var r=document.getElementById('reason');
     if(params.exists) {
-        r.appendChild(document.createTextNode(params.exception));
+        var textnode = document.createTextNode(locale.getFormattedString('eexecute'));
     } else {
         var textnode = document.createTextNode(locale.getFormattedString('enoent', [params.path]));
 
diff --git a/chrome/content/cacheobj.js b/chrome/content/cacheobj.js
index d9df244..af09029 100644
--- a/chrome/content/cacheobj.js
+++ b/chrome/content/cacheobj.js
@@ -250,13 +250,12 @@ CacheObj.prototype.edit = function(extension) {
         // to the process.
         var args = [filename];
         var result = {};
-        process.run(false, args, args.length, result);
+        var ec = process.run(true, args, args.length, result);
         this._is_watching = true;
     } catch(e) {
         var params = {out:null,
                       exists: program.exists(),
-                      path: program.path,
-                      exception: e };
+                      path: program.path};
         window.openDialog('chrome://itsalltext/chrome/badeditor.xul',
                           null,
                           "chrome,titlebar,toolbar,centerscreen,modal",
diff --git a/chrome/locale/en-US/badeditor.dtd b/chrome/locale/en-US/badeditor.dtd
index 2d43157..41ccfe0 100644
--- a/chrome/locale/en-US/badeditor.dtd
+++ b/chrome/locale/en-US/badeditor.dtd
@@ -1,9 +1,9 @@
 <!ENTITY title              "It's All Text! was unable to open your editor">
 <!ENTITY header             "Unable to open your editor">
 <!ENTITY pref.label         "Preferences">
-<!ENTITY helptext           "I was unable to run your editor.
+<!ENTITY helptext           "It's All Text! was unable to run your editor.
 
-You can now either cancel your editor or you can use the preferences to choose a new editor.  Please make sure that you use the full path to the editor and that the editor is executable.
+You can now either cancel your edit or you can use the preferences to choose a new editor.  Please make sure that you use the full path to the editor and that the editor is marked executable.
 
 Thank you.
 ">
diff --git a/chrome/locale/en-US/badeditor.properties b/chrome/locale/en-US/badeditor.properties
index f1614ff..5551f4b 100644
--- a/chrome/locale/en-US/badeditor.properties
+++ b/chrome/locale/en-US/badeditor.properties
@@ -1 +1,3 @@
 enoent=The path '%1$S' does not exist.
+eexitcode=Your editor exited with an error or failed to run.
+eexecute=Unable to execute your editor.

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/itsalltext.git