[Pkg-mozext-commits] [itsalltext] 413/459: Renamed too-generic #ids in XUL

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch master
in repository itsalltext.

commit 6a04476fd3aab0226641f9e296776232de0525e4
Author: Christian Höltje <docwhat at gerf.org>
Date:   Mon May 13 23:32:22 2013 -0400

    Renamed too-generic #ids in XUL
    
    This fixes two warnings in the AMO validator:
    
        Overlay contains generically-named IDs
        Warning: An overlay is using a generically-named ID that could cause
        compatibility problems with other add-ons. Add-ons must namespace
        all IDs in the overlay, in the same way that JavaScript objects must
        be namespaced.
---
 src/chrome/content/badeditor.js    | 2 +-
 src/chrome/content/badeditor.xul   | 4 ++--
 src/chrome/content/preferences.js  | 6 +++---
 src/chrome/content/preferences.xul | 2 +-
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/chrome/content/badeditor.js b/src/chrome/content/badeditor.js
index 9dba4de..4693bde 100644
--- a/src/chrome/content/badeditor.js
+++ b/src/chrome/content/badeditor.js
@@ -11,7 +11,7 @@ function onOK() {
     return true;
 }
 function doOnload() {
-    var locale = document.getElementById("strings"),
+    var locale = document.getElementById("itsalltext-strings"),
     params = window['arguments'][0],
     reason = document.getElementById('reason'),
     textnode = '**error**';
diff --git a/src/chrome/content/badeditor.xul b/src/chrome/content/badeditor.xul
index a449ecc..7924f8e 100644
--- a/src/chrome/content/badeditor.xul
+++ b/src/chrome/content/badeditor.xul
@@ -14,7 +14,7 @@
 
   <script type="application/x-javascript" src="chrome://itsalltext/content/badeditor.js"/>
   <stringbundleset id="strbundles">
-    <stringbundle id="strings" src="chrome://itsalltext/locale/badeditor.properties"/>
+    <stringbundle id="itsalltext-strings" src="chrome://itsalltext/locale/badeditor.properties"/>
   </stringbundleset>
 
   <dialogheader title="&header;"/>
@@ -27,7 +27,7 @@
       </description>
     </groupbox>
   </vbox>
-    
+
 </dialog>
 <!-- Local Variables: -->
 <!-- mode: xml -->
diff --git a/src/chrome/content/preferences.js b/src/chrome/content/preferences.js
index 914a04d..b034b53 100644
--- a/src/chrome/content/preferences.js
+++ b/src/chrome/content/preferences.js
@@ -7,7 +7,7 @@
  * Open a filepicker to select the value of the editor.
  */
 function pref_editor_select() {
-    var locale = document.getElementById("strings"),
+    var locale = document.getElementById("itsalltext-strings"),
     pref_editor = document.getElementById('pref_editor'),
     nsIFilePicker = Components.interfaces.nsIFilePicker,
     fp,
@@ -48,7 +48,7 @@ function pref_editor_select() {
 }
 
 function pref_workingdir_select() {
-    var locale = document.getElementById("strings"),
+    var locale = document.getElementById("itsalltext-strings"),
     pref_workingdir = document.getElementById('pref_workingdir'),
     nsIFilePicker = Components.interfaces.nsIFilePicker,
     fp,
@@ -127,7 +127,7 @@ function setHelp(text) {
 }
 
 function pref_onload() {
-    var locale = document.getElementById("strings"),
+    var locale = document.getElementById("itsalltext-strings"),
     editor,
     workingdir,
     box,
diff --git a/src/chrome/content/preferences.xul b/src/chrome/content/preferences.xul
index a312cd8..93884c3 100644
--- a/src/chrome/content/preferences.xul
+++ b/src/chrome/content/preferences.xul
@@ -8,7 +8,7 @@
             buttons="accept,cancel">
 
   <stringbundleset id="strbundles">
-    <stringbundle id="strings" src="chrome://itsalltext/locale/preferences.properties" />
+    <stringbundle id="itsalltext-strings" src="chrome://itsalltext/locale/preferences.properties" />
   </stringbundleset>
 
   <prefpane

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/itsalltext.git