[Pkg-mozext-commits] [adblock-plus-element-hiding-helper] 162/483: Backing out changeset 6ce29ca41736 (Prevent tooltips from disappearing automatically) - causes focus issues that are hard to resolve

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch master
in repository adblock-plus-element-hiding-helper.

commit 256c0529b0068c905ecdab26de06d81ebf5e60d3
Author: Wladimir Palant <trev at adblockplus.org>
Date:   Wed Apr 29 09:35:50 2009 +0200

    Backing out changeset 6ce29ca41736 (Prevent tooltips from disappearing automatically) - causes focus issues that are hard to resolve
    
    --HG--
    extra : rebase_source : 85230960610b5d5f759b4b35e856190d532ea877
---
 chrome/content/aardvark.js | 5 -----
 chrome/content/overlay.js  | 5 -----
 chrome/content/overlay.xul | 4 ++--
 3 files changed, 2 insertions(+), 12 deletions(-)

diff --git a/chrome/content/aardvark.js b/chrome/content/aardvark.js
index ee6eea6..2aa8a2d 100644
--- a/chrome/content/aardvark.js
+++ b/chrome/content/aardvark.js
@@ -563,11 +563,9 @@ ehhAardvark.viewSource = function (elem)
 
   var sourceBox = document.getElementById("ehh-viewsource");
   if ((sourceBox.getAttribute("_moz-menuactive") == "true" || sourceBox.state == "open") && this.commentElem == elem) {
-    ehhViewSourceHidden = true;
     sourceBox.hidePopup();
     return true;
   }
-  ehhViewSourceHidden = true;
   sourceBox.hidePopup();
 
   while (sourceBox.firstChild)
@@ -578,7 +576,6 @@ ehhAardvark.viewSource = function (elem)
   var x = this.mouseX;
   var y = this.mouseY;
   setTimeout(function() {
-    ehhViewSourceHidden = false;
     sourceBox.showPopup(document.documentElement, x, y, "tooltip", "topleft", "topleft");
   }, 500);
   return true;
@@ -680,13 +677,11 @@ ehhAardvark.showMenu = function ()
 {
   var helpBox = document.getElementById("ehh-helpbox");
   if (helpBox.getAttribute("_moz-menuactive") == "true" || helpBox.state == "open") {
-    ehhHelpHidden = true;
     helpBox.hidePopup();
     return true;
   }
 
   // Show help box
-  ehhHelpHidden = false;
   helpBox.showPopup(this.browser, -1, -1, "tooltip", "topleft", "topleft");
   return true;
 }
diff --git a/chrome/content/overlay.js b/chrome/content/overlay.js
index ae7de22..bb44e84 100644
--- a/chrome/content/overlay.js
+++ b/chrome/content/overlay.js
@@ -22,9 +22,6 @@
  *
  * ***** END LICENSE BLOCK ***** */
 
-var ehhHelpHidden = true;
-var ehhViewSourceHidden = true;
-
 // This will be called from overlayBasic - only if Adblock Plus is installed
 // and the version is correct
 function ehhInit2() {
@@ -67,8 +64,6 @@ function ehhGetBrowser() {
 }
 
 function ehhHideTooltips() {
-  ehhHelpHidden = true;
-  ehhViewSourceHidden = true;
   document.getElementById("ehh-helpbox").hidePopup();
   document.getElementById("ehh-commandlabel").hidePopup();
   document.getElementById("ehh-viewsource").hidePopup();
diff --git a/chrome/content/overlay.xul b/chrome/content/overlay.xul
index 4e70747..33afedb 100644
--- a/chrome/content/overlay.xul
+++ b/chrome/content/overlay.xul
@@ -32,7 +32,7 @@
   <script type="application/x-javascript" src="aardvark.js"/>
   
   <popupset id="abp-popupset">
-    <tooltip id="ehh-helpbox" orient="vertical" onpopuphiding="return ehhHelpHidden;">
+    <tooltip id="ehh-helpbox" noautohide="true" orient="vertical">
       <description id="ehh-helpbox-title" value="&helpbox.title;"/>
 
       <grid flex="1">
@@ -47,7 +47,7 @@
       <description id="ehh-commandlabel-key"/>
       <description id="ehh-commandlabel-label"/>
     </tooltip>
-    <tooltip id="ehh-viewsource" orient="vertical" onpopuphiding="return ehhViewSourceHidden;"/>
+    <tooltip id="ehh-viewsource" noautohide="true" orient="vertical"/>
   </popupset>
 
   <popup id="abp-status-popup">

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/adblock-plus-element-hiding-helper.git