[Pkg-mozext-commits] [perspectives-extension] 07/14: Pers_report - Remove call to nsIDNSService.resolve()

David Prévot taffit at moszumanska.debian.org
Sat Jun 20 21:28:47 UTC 2015


This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch master
in repository perspectives-extension.

commit e05256e839555846d58a799a42e498b2c8c23145
Author: Dave Schaefer <dave.schaefer at gmail.com>
Date:   Mon Jun 1 00:08:01 2015 -0600

    Pers_report - Remove call to nsIDNSService.resolve()
    
    Even though this code was never called,
    its existence flagged Perspectives as failing AMO review policies.
    See GH #160.
    
    Removing outright so it's not parsed or picked up.
---
 plugin/chrome/content/report.js | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/plugin/chrome/content/report.js b/plugin/chrome/content/report.js
index 57360ac..8d7e88a 100644
--- a/plugin/chrome/content/report.js
+++ b/plugin/chrome/content/report.js
@@ -28,12 +28,10 @@ var Pers_report = {
         var iface = Components.interfaces.nsIDNSService;
         var dns = cls.getService(iface);
         var ips = Array();
-        var nsrecord = dns.resolve(hostname, true);
-
-        while (nsrecord && nsrecord.hasMore()) {
-            ips[ips.length] = nsrecord.getNextAddrAsString();
-        }
-
+        // DEVELOPER NOTE:
+        // Report Attack functionality is currently puposely disabled.
+        // We need to make sure it does not violate reporter privacy
+        // before turning it back on.
         return ips;
     },  
  

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/perspectives-extension.git



More information about the Pkg-mozext-commits mailing list